Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation website cookie problem #1622

Closed
Tichael opened this issue Nov 16, 2018 · 5 comments
Closed

Documentation website cookie problem #1622

Tichael opened this issue Nov 16, 2018 · 5 comments
Labels

Comments

@Tichael
Copy link

Tichael commented Nov 16, 2018

Hi, I have a small but annoying bug on the documentation website: the "Why we use cookies" banner won't remember that I've clicked "I understand".

In case it can help, the value of "dx-cookie-policy" is "Fri%20Nov%2016%202018%2010%3A18%3A59%20GMT-0500%20%28heure%20normale%20de%20l%u2019Est%20nord-am%E9ricain%29" (My computer and browser are in French, so maybe it's that. The value says "Fri Nov 16 2018 10:18:59 GTM-0500 (heure normale de l'Est nord-américain)").

Like I said, not a big deal, but it's still annoying to dismiss the banner each time I change page, or to just forget it and let it eat a part of the page.

@SergeyAlexeev SergeyAlexeev self-assigned this Nov 26, 2018
@SergeyAlexeev
Copy link
Contributor

Hi,
 
I can't reproduce the issue on my side. I used the 'GMT-0500 (Eastern Standard Time)' timezone on my PC and the 'Why We Use Cookies..' message appears only once.
 
Could you try to clear browser cookies? Does the problem still exist?

@Tichael
Copy link
Author

Tichael commented Nov 27, 2018

I tried what you asked me to do, and even tried a guest Chrome session and the problem is still there. The cookie is created when I click "I understand", but the banner still appear on the next page or reload.

I also tried on Firefox, and still I have the same issue.

Maybe it's because my system is in French? I would need to try on an English system to confirm that (I'll try with a virtual machine and give you an update then).

@Tichael
Copy link
Author

Tichael commented Nov 27, 2018

I can confirm, on a Ubuntu VM in French (Canada), the cookie value doesn't seem to be correctly interpreted and the banner will show on each pages. When I change the language to English (Canada) and accept (again) the cookie usage, it doesn't show anymore on reload or page change. If I switch back to French (Canada), the banner won't show up since the latest cookie value is the one with the English date version. If I clear the cookies and try again, now the problem has returned.

So I think the cookie value is not correctly translated from French to a valid date for the verification.

@SergeyAlexeev
Copy link
Contributor

SergeyAlexeev commented Nov 29, 2018

Thank you for the additional information! I reproduced the problem. We'll create a PR that will fix it soon.

@lock
Copy link

lock bot commented Jun 15, 2019

This thread has been automatically locked since it is closed and there has not been any recent activity. Please open a new issue for related bugs or feature requests.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants