Skip to content

Commit

Permalink
refactor(react-grid-material-ui): get rid of the Paper wrapper (#487)
Browse files Browse the repository at this point in the history
BREAKING CHANGE:
 
To make Grid for Material UI more flexible we've stopped using the [Paper](https://material-ui-1dab0.firebaseapp.com/demos/paper/) component inside the Grid's layout. 
 
It allows placing our Grid to an existing Paper with other components. For example:

```js
<Paper>
  <Button>Products</Button>
  <Button>Customers</Button>
  <Button>Sales</Button>
  <Grid
    /* ... */
  >
    {/* ... */}
  </Grid>
</Paper>
```
  • Loading branch information
SergeyAlexeev authored Nov 18, 2017
1 parent fdfab56 commit 2e40de9
Show file tree
Hide file tree
Showing 55 changed files with 981 additions and 886 deletions.
1 change: 0 additions & 1 deletion packages/dx-react-demos/src/demo-viewer/demo-renderer.jsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import React from 'react';
import PropTypes from 'prop-types';

import { themes, demos } from '../demo-registry';

export const DemoRenderer = ({
Expand Down
18 changes: 11 additions & 7 deletions packages/dx-react-demos/src/material-ui/basic/basic.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ import {
TableHeaderRow,
} from '@devexpress/dx-react-grid-material-ui';

import Paper from 'material-ui/Paper';

import {
generateRows,
globalSalesValues,
Expand All @@ -30,13 +32,15 @@ export default class Demo extends React.PureComponent {
const { rows, columns } = this.state;

return (
<Grid
rows={rows}
columns={columns}
>
<TableView />
<TableHeaderRow />
</Grid>
<Paper>
<Grid
rows={rows}
columns={columns}
>
<TableView />
<TableHeaderRow />
</Grid>
</Paper>
);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {
TableHeaderRow,
} from '@devexpress/dx-react-grid-material-ui';

import { TableCell } from 'material-ui';
import { TableCell, Paper } from 'material-ui';

import {
generateRows,
Expand Down Expand Up @@ -68,13 +68,15 @@ export default class Demo extends React.PureComponent {
const { rows, columns } = this.state;

return (
<Grid
rows={rows}
columns={columns}
>
<TableView tableCellTemplate={this.tableCellTemplate} />
<TableHeaderRow />
</Grid>
<Paper>
<Grid
rows={rows}
columns={columns}
>
<TableView tableCellTemplate={this.tableCellTemplate} />
<TableHeaderRow />
</Grid>
</Paper>
);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {
TableHeaderRow,
} from '@devexpress/dx-react-grid-material-ui';

import { TableRow } from 'material-ui';
import { TableRow, Paper } from 'material-ui';

import {
generateRows,
Expand Down Expand Up @@ -41,13 +41,15 @@ export default class Demo extends React.PureComponent {
const { rows, columns } = this.state;

return (
<Grid
rows={rows}
columns={columns}
>
<TableView tableRowTemplate={this.tableRowTemplate} />
<TableHeaderRow />
</Grid>
<Paper>
<Grid
rows={rows}
columns={columns}
>
<TableView tableRowTemplate={this.tableRowTemplate} />
<TableHeaderRow />
</Grid>
</Paper>
);
}
}
22 changes: 12 additions & 10 deletions packages/dx-react-demos/src/material-ui/column-chooser/basic.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -39,16 +39,18 @@ export default class Demo extends React.PureComponent {
return (
<MUIGrid container>
<MUIGrid item xs={12} sm={9}>
<Grid
rows={rows}
columns={columns}
>
<TableView />
<TableHeaderRow />
<TableColumnVisibility
hiddenColumns={hiddenColumns}
/>
</Grid>
<Paper>
<Grid
rows={rows}
columns={columns}
>
<TableView />
<TableHeaderRow />
<TableColumnVisibility
hiddenColumns={hiddenColumns}
/>
</Grid>
</Paper>
</MUIGrid>
<MUIGrid item xs={12} sm={3}>
<Paper>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {
TableHeaderRow,
TableColumnReordering,
} from '@devexpress/dx-react-grid-material-ui';

import Paper from 'material-ui/Paper';
import {
generateRows,
} from '../../demo-data/generator';
Expand Down Expand Up @@ -35,18 +35,20 @@ export default class Demo extends React.PureComponent {
const { rows, columns, columnOrder } = this.state;

return (
<Grid
rows={rows}
columns={columns}
>
<DragDropContext />
<TableView />
<TableColumnReordering
order={columnOrder}
onOrderChange={this.changeColumnOrder}
/>
<TableHeaderRow allowDragging />
</Grid>
<Paper>
<Grid
rows={rows}
columns={columns}
>
<DragDropContext />
<TableView />
<TableColumnReordering
order={columnOrder}
onOrderChange={this.changeColumnOrder}
/>
<TableHeaderRow allowDragging />
</Grid>
</Paper>
);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {
TableHeaderRow,
TableColumnReordering,
} from '@devexpress/dx-react-grid-material-ui';

import Paper from 'material-ui/Paper';
import {
generateRows,
} from '../../demo-data/generator';
Expand All @@ -29,17 +29,19 @@ export default class Demo extends React.PureComponent {
const { rows, columns } = this.state;

return (
<Grid
rows={rows}
columns={columns}
>
<DragDropContext />
<TableView />
<TableColumnReordering
defaultOrder={['city', 'sex', 'car', 'name']}
/>
<TableHeaderRow allowDragging />
</Grid>
<Paper>
<Grid
rows={rows}
columns={columns}
>
<DragDropContext />
<TableView />
<TableColumnReordering
defaultOrder={['city', 'sex', 'car', 'name']}
/>
<TableHeaderRow allowDragging />
</Grid>
</Paper>
);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {
TableHeaderRow,
TableColumnResizing,
} from '@devexpress/dx-react-grid-material-ui';

import Paper from 'material-ui/Paper';
import {
generateRows,
} from '../../demo-data/generator';
Expand Down Expand Up @@ -35,17 +35,19 @@ export default class Demo extends React.PureComponent {
const { rows, columns, columnWidths } = this.state;

return (
<Grid
rows={rows}
columns={columns}
>
<TableView />
<TableColumnResizing
columnWidths={columnWidths}
onColumnWidthsChange={this.changeColumnWidths}
/>
<TableHeaderRow allowResizing />
</Grid>
<Paper>
<Grid
rows={rows}
columns={columns}
>
<TableView />
<TableColumnResizing
columnWidths={columnWidths}
onColumnWidthsChange={this.changeColumnWidths}
/>
<TableHeaderRow allowResizing />
</Grid>
</Paper>
);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {
TableHeaderRow,
TableColumnResizing,
} from '@devexpress/dx-react-grid-material-ui';

import Paper from 'material-ui/Paper';
import {
generateRows,
} from '../../demo-data/generator';
Expand All @@ -31,14 +31,16 @@ export default class Demo extends React.PureComponent {
const { rows, columns, defaultColumnWidths } = this.state;

return (
<Grid
rows={rows}
columns={columns}
>
<TableView />
<TableColumnResizing defaultColumnWidths={defaultColumnWidths} />
<TableHeaderRow allowResizing />
</Grid>
<Paper>
<Grid
rows={rows}
columns={columns}
>
<TableView />
<TableColumnResizing defaultColumnWidths={defaultColumnWidths} />
<TableHeaderRow allowResizing />
</Grid>
</Paper>
);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
TableEditRow,
TableEditColumn,
} from '@devexpress/dx-react-grid-material-ui';

import Paper from 'material-ui/Paper';
import {
generateRows,
defaultNestedColumnValues,
Expand Down Expand Up @@ -91,19 +91,21 @@ export default class Demo extends React.PureComponent {
const { rows, columns } = this.state;

return (
<Grid
rows={rows}
columns={columns}
getRowId={getRowId}
>
<EditingState
onCommitChanges={this.commitChanges}
/>
<TableView />
<TableHeaderRow />
<TableEditRow />
<TableEditColumn allowAdding allowEditing allowDeleting />
</Grid>
<Paper>
<Grid
rows={rows}
columns={columns}
getRowId={getRowId}
>
<EditingState
onCommitChanges={this.commitChanges}
/>
<TableView />
<TableHeaderRow />
<TableEditRow />
<TableEditColumn allowAdding allowEditing allowDeleting />
</Grid>
</Paper>
);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
TableEditRow,
TableEditColumn,
} from '@devexpress/dx-react-grid-material-ui';

import Paper from 'material-ui/Paper';
import {
generateRows,
defaultNestedColumnValues,
Expand Down Expand Up @@ -89,21 +89,23 @@ export default class Demo extends React.PureComponent {
const { rows, columns } = this.state;

return (
<Grid
rows={rows}
columns={columns}
getRowId={getRowId}
getCellValue={getCellValue}
>
<EditingState
createRowChange={createRowChange}
onCommitChanges={this.commitChanges}
/>
<TableView />
<TableHeaderRow />
<TableEditRow />
<TableEditColumn allowAdding allowEditing allowDeleting />
</Grid>
<Paper>
<Grid
rows={rows}
columns={columns}
getRowId={getRowId}
getCellValue={getCellValue}
>
<EditingState
createRowChange={createRowChange}
onCommitChanges={this.commitChanges}
/>
<TableView />
<TableHeaderRow />
<TableEditRow />
<TableEditColumn allowAdding allowEditing allowDeleting />
</Grid>
</Paper>
);
}
}
Loading

0 comments on commit 2e40de9

Please sign in to comment.