Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit (finally) manual conference creation #196

Closed
Strehk opened this issue May 30, 2024 · 6 comments · Fixed by #199
Closed

Omit (finally) manual conference creation #196

Strehk opened this issue May 30, 2024 · 6 comments · Fixed by #199
Assignees
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@Strehk
Copy link
Member

Strehk commented May 30, 2024

We need to omit the plus at the home screen and the corresponding page to create conferences

@Strehk Strehk added bug Something isn't working good first issue Good for newcomers labels May 30, 2024
@Strehk Strehk added this to the MUN-SH 2025 milestone May 30, 2024
@ahsanfarooq210
Copy link
Contributor

Hi @TadeSF. I want to work on this issue

@Strehk
Copy link
Member Author

Strehk commented Jun 4, 2024

Hey @ahsanfarooq210, sure, go ahaed!

I was referring to this whole folder which can be safely deleted since it has no functionality at the moment: chase/frontend/app/app/admin/(start)

And you can find and remove the Plus-Button in this component:
chase/frontend/components/home/navbar.tsx

You might not see the button in your local development, since it is only an Icon that you can't render atm without FontAwesome Pro Icons. But you can take a look at this website to see the button in action, which should be removed.

Do you have any more questions?

CleanShot 2024-06-04 at 16 10 41@2x

P.S. @m1212e do you have something to add / objections to deleting the pages? I don't think we have already talked about this in detail.

@m1212e
Copy link
Member

m1212e commented Jun 5, 2024

No we should take it out until we got the actual functionality to back that up!

@ahsanfarooq210
Copy link
Contributor

Hi @TadeSF .I had a few deadlines to finish my job on an urgent priority. This issue will be resolved within this week.

@ahsanfarooq210
Copy link
Contributor

Hi @TadeSF Please review the PR

@m1212e
Copy link
Member

m1212e commented Jun 25, 2024

No worries, you can work on this whenever you want, it's your free time! Thanks for the contribution. We currently do a big rework on some project structures and will postpone this during this period. We will take care of this as soon as possible!

@Strehk Strehk linked a pull request Jun 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants