Use a UUID instead of volume name for fstab on Mac #215
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #212.
Before we were using a volume name for the
/etc/fstab
entry for the Nix Store, while this worked on our testing Macs, it was insufficiently robust for "Real" Macs.This introduces a new Darwin-only action called
CreateFstabEntry
which inquires withdiskutil info ${LABEL}
for a UUID and then sets that in the/etc/fstab
.Unfortunately adding a test for this is rather hard since we can't reboot CI macs.
Checklist
cargo fmt
nix build
nix flake check
Validating with
install.determinate.systems
If a maintainer has added the
upload to s3
label to this PR, it will become available for installation viainstall.determinate.systems
: