Allow users to answer e at prompts #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cole-h
reviewed
Jan 12, 2023
src/cli/interaction.rs
Outdated
| "n" | ||
| } | ||
| .green(), | ||
| maybe_explain = if !explaining { |
There was a problem hiding this comment.
What is this explaining bool for? At first I thought it was something like "can this prompt be explained", then I thought it was "are we explaining this prompt", and now I'm not sure.
If it's the first, could it be renamed to can_explain, and if it's the second, can it be renamed to already_explaining or is_explaining or currently_explaining or something?
| @@ -3,24 +3,58 @@ use std::io::{stdin, stdout, BufRead, Write}; | |||
| use eyre::{eyre, WrapErr}; | |||
| use owo_colors::OwoColorize; | |||
|
|
|||
| #[derive(Copy, Clone, Debug, PartialEq, Eq)] | |||
| pub enum PromptChoice { | |||
cole-h
approved these changes
Jan 12, 2023
| maybe_explain = if !currently_explaining { | ||
| format!( | ||
| "/{}", | ||
| if default == PromptChoice::Explain { |
There was a problem hiding this comment.
Since it's not obvious what E could be, maybe in the future, we should change the prompt to look like ([Y]es/[n]o/[e]xplain) (and all its variations.
Hoverbear
deleted the
hoverbear/ds-613-allow-users-to-answer-e-at-install
branch
This was referenced May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #177