Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor macOS fixups #1346

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Minor macOS fixups #1346

wants to merge 2 commits into from

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Dec 9, 2024

Description

Extracted from #1147. These changes don't change the receipt format and are thus safe to merge as-is without a minor version bump.

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

This is returned with the message "Operation already in progress".
However, `print` doesn't actually start anything, so I highly doubt this
can ever trigger. This has existed since the beginning of this file, but
I believe it's a relic of some leftover testing with `launchctl load` /
`launchctl unload` / `launchctl bootstrap` / `launchctl bootout`, which
likely could return this.
@cole-h cole-h added this to the 0.32.2 milestone Dec 9, 2024
@cole-h cole-h requested a review from grahamc December 9, 2024 20:09
@cole-h cole-h enabled auto-merge (squash) December 9, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant