Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to node20 #40

Closed
lovesegfault opened this issue Oct 12, 2023 · 2 comments · Fixed by #41
Closed

Update to node20 #40

lovesegfault opened this issue Oct 12, 2023 · 2 comments · Fixed by #41

Comments

@lovesegfault
Copy link

The action is still on node16, but by default configured runners on NixOS only come with node20, causing the action to fail.

It should probably be moved to node20, if there are no drawbacks?

nix-installer-action/action.yml

Lines 108 to 111 in 07ebb8d

runs:
using: "node16"
main: 'dist/index.js'
post: 'dist/index.js'

@grahamc grahamc mentioned this issue Oct 12, 2023
Merged
3 tasks
@grahamc
Copy link
Member

grahamc commented Oct 12, 2023

I just moved it to node20 in #41. I don't think there is any reason to avoid the update and typescript didn't even recompile differently. Let's see what the tests do and find out!

@grahamc
Copy link
Member

grahamc commented Oct 12, 2023

Released in v6 :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update the action to use node20 DeterminateSystems/nix-installer-action
2 participants
@grahamc @lovesegfault