Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

figure out how to make type keyword blue #147

Open
DetachHead opened this issue Mar 14, 2024 · 1 comment
Open

figure out how to make type keyword blue #147

DetachHead opened this issue Mar 14, 2024 · 1 comment
Labels
language server vscode syntax highlighting issues with vscode's native python syntax highlighting rather than an issue with our LSP vscode the extension for vscode/vscodium

Comments

@DetachHead
Copy link
Owner

DetachHead commented Mar 14, 2024 •
edited
Loading

image
image

currently it's purple (SemanticTokenTypes.keyword) but i think the type keyword is more similar to the blue keywords than the purple ones.

though i have no idea what the distinction is supposed to be. there are cases where the same keyword is highlighted blue or purple for seemingly no reason (#148)
@DetachHead DetachHead added language server vscode the extension for vscode/vscodium labels Mar 14, 2024
@DetachHead DetachHead mentioned this issue Mar 14, 2024
Open
@DetachHead DetachHead added vscode syntax highlighting issues with vscode's native python syntax highlighting rather than an issue with our LSP and removed LSP: semantic highlighting labels Apr 26, 2024
@DetachHead
Copy link
Owner Author

gonna wait and see what the response is to microsoft/pylance-release#5824 before investing any more effort into things that should be handled by the syntax highlighter

@DetachHead DetachHead mentioned this issue Apr 28, 2024
Open
@DetachHead DetachHead mentioned this issue Sep 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
language server vscode syntax highlighting issues with vscode's native python syntax highlighting rather than an issue with our LSP vscode the extension for vscode/vscodium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DetachHead