Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap dependency is pinned to an insecure version of bootstrap #55

Closed
cjcodes opened this issue Jul 6, 2019 · 2 comments
Closed

Comments

@cjcodes
Copy link

cjcodes commented Jul 6, 2019

Expected Behavior

npm audit should pass

Current Behavior

npm audit shows a vulnerability in 4.1.3:

┌───────────────┬──────────────────────────────────────────────────────────────┐
│ Moderate      │ Cross-Site Scripting                                         │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ bootstrap                                                    │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=3.4.1 <4.0.0 || >=4.3.1                                    │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ shards-react                                                 │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ shards-react > shards-ui > bootstrap                         │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://npmjs.com/advisories/891                             │
└───────────────┴──────────────────────────────────────────────────────────────┘

Possible Solution

Upgrade bootstrap to >= 4.3.1

Steps to Reproduce

  1. Install shards-react or any other module that depends on this repo
  2. Run npm audit
@cjcodes
Copy link
Author

cjcodes commented Jul 6, 2019

I would PR this, but I dunno how to manually verify that there are no regressions.

@cookieshell cookieshell mentioned this issue Jul 30, 2019
@cookieshell
Copy link
Member

Fixed in #57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants