Add "Show in Dependency-Graph" Button in "Affected Projects" List [improved version] #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a `Show in Dependency-Graph` button to the every project in the `Affected Projects` tab of a vulnerability that highlights the affected component in the project's dependency graph Signed-off-by: RBickert <[email protected]>
Clicking on a project from the "Affected Projects"-tab of a vulnerability now opens the project's "Findings"-tab, showing only the expanded vulnerability Signed-off-by: RBickert <[email protected]>
…-graph-from-affected-projects Add "Show in Dependency-Graph" Button in "Affected Projects" List
Adds a `Show in Dependency-Graph` button to the every project in the `Affected Projects` tab of a vulnerability that highlights the affected component in the project's dependency graph Signed-off-by: RBickert <[email protected]>
Clicking on a project from the "Affected Projects"-tab of a vulnerability now opens the project's "Findings"-tab, showing only the expanded vulnerability Signed-off-by: RBickert <[email protected]>
* Fix bug: If opening graph for component, showing outdated versions did no longer work * Dependency graph now supports multiple UUIDs of components to be searched for * Affected components list now opens graph with all affected components Signed-off-by: Ralf King <[email protected]>
…-from-affected-projects' into master-open-dependency-graph-from-affected-projects # Conflicts: # src/views/portfolio/vulnerabilities/AffectedProjects.vue
nscuro
reviewed
Dec 10, 2023
Signed-off-by: Ralf King <[email protected]>
…mponents instead of only one. Signed-off-by: Ralf King <[email protected]>
Signed-off-by: Ralf King <[email protected]>
|
@nscuro Could you consider removing the code analysis rule triggering on things like I fixed the one in this PR but I see this failing other PRs, too. and I find it better you define all given parameters even if you do not use them right now, cause it makes it clear that they are available when you work on this part later. |
|
@rkg-mm Codacy appears to be using ESLint behind the scenes, so you can just add But yeah I think Codacy in general needs some tweaking to be a better fit for the project in general. |
nscuro
approved these changes
Dec 10, 2023
Closed
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the Show in Dependency-Graph button to the every project in the Affected Projects tab of a vulnerability, but only if the affected project has a dependency graph.
Clicking the button redirects the user to the projects dependency graph and highlights the affected component.
Clicking on the project link in a vulnerabilities Affected Projects tab opens the project's Audit Vulnerabilities tab, showing only the expanded finding.
Improved version, replaces #573 :
Addressed Issue
#533
Additional Details
Backend PR: DependencyTrack/dependency-track#3285
The redirect to a project's Audit Vulnerabilities tab works by opening a specific URL and searching for the matrix of a finding.
By adding a hidden Matrix column to the table, the wanted finding can be filtered and expanded by searching for it's matrix.
.../projects/<projectUUID>/findings/<affectedComponentUUID>/<vulnerabilityUUID><projectUUID>:<affectedComponentUUID>:<vulnerabilityUUID>Checklist
This PR introduces new or alters existing behavior, and I have updated the documentation accordingly