Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project view should not preload all tabs #660

Open
2 tasks done
rkg-mm opened this issue Dec 2, 2023 · 2 comments
Open
2 tasks done

Project view should not preload all tabs #660

rkg-mm opened this issue Dec 2, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@rkg-mm
Copy link
Contributor

rkg-mm commented Dec 2, 2023

Current Behavior

When opening a project, all tables in all tabs are auto-loaded directly, causing some delay in the UI and unnecessary load on the server.
The loaded data is used to also populate the number on the tab-badge, so just making tabs lazy will have side effects.

Proposed Behavior

Tabs should be loaded only when being opened.

This could be done by applying the lazy attribute, to the tab, but that has 2 drawbacks:

  1. The badge with number on the tab name will not be populated, as it relies on the data loaded in the tab
  2. whenever you switch between tabs, the old tab content gets discarded, causing multiple loads again which would not be necessary

Possible solution to both problems:

  1. Check if the data required for tab-badge-numbers is available e.g. in the project object, or if it could be loaded in a single additional call e.g. loading a metrics object
  2. Instead using the lazy attribute, do a lazy initialize of the table server loading, triggering the first load when the tab gets activated.

Checklist

@rkg-mm rkg-mm added the enhancement New feature or request label Dec 2, 2023
@nscuro
Copy link
Member

nscuro commented Feb 3, 2024

FYI slow page loads were amplified by each table's content being loaded more than once. This happened because application of user preferences for column visibility silently triggered a reload of each table. This is now fixed with #727.

@rkg-mm
Copy link
Contributor Author

rkg-mm commented Feb 4, 2024

@nscuro I fixed the same issue in another PR but still created this enhancement request here, because it provides further optimization possibilities

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants