Skip to content

Commit

Permalink
fix(common): calculate percentage to tenth decimal place
Browse files Browse the repository at this point in the history
  • Loading branch information
setchy committed Jan 28, 2024
1 parent a2b7ce2 commit 683cfda
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions src/shared/common.js
Original file line number Diff line number Diff line change
Expand Up @@ -410,17 +410,17 @@ $common.valueWithDefault = function valueWithDefault(variable, defaultValue) {
* function will return a percentage rounded to the tenth decimal place.
*/
$common.calcProgressPercent = function calcProgressPercent(total, completed) {
if (total > 0) {
if (completed > total) {
// In something has already been completed (e.g. suppressed) and the completed value
// is greater than the total, return 100%
return 100;
} else if (total > 0) {
if (completed === 0) {
return 0;
} else {
let percentage = (completed / total) * 100;
return Math.round(percentage);
return Math.round(percentage * 10) / 10;
}
} else if (completed > total) {
// In something has already been completed (e.g. suppressed) and the completed value
// is greater than the total, return 100%
return 100;
}
return 0; // the absence of work does not imply progress.
};
Expand Down

0 comments on commit 683cfda

Please sign in to comment.