-
-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added option to set gradient backgrounds #481
Conversation
1d93d0b
to
6349ac0
Compare
Signed-off-by: Mohd Faraz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this feature 👍
I have a few comments regarding the implementation.
The demo site seems to have multiple bugs introduced regarding adding and deleting advanced properties and defaults not getting filtered. If it's too complicated to get it to work, it's fine if the demo site is updated in a separate PR. Same PR is also fine if its fully working.
(Also, I'd prefer force-pushing to be avoided since it makes it harder to track progress on the PR and with syncing changes)
* background=DEG,COLOR1,COLOR2,....COLORN Signed-off-by: Mohd Faraz <[email protected]>
Check new commit, is everything fine |
The backend looks great! Thanks for the continued progress 👍 Is it fine with you if I add some commits to fix some issues with the demo site? |
Ya why not, which features? |
Here are some things I noticed
I'm refactoring some stuff and I'll probably fix most of these along the way. 👍 |
Do I need to see them or you are handling? |
Looks great. |
Almost everything looks like it's pretty good right now. One thing left I can think to consider is whether we should allow users to still set background colors on the demo site without controlling both a start and end color. For example, maybe there could be a radio input to select between solid color and gradient for the background. Possibly it could be two separate menu items, "background (solid)" and "background (gradient)", and adding one would disable the other from being chosen. I'm not entirely sure what's best. What do you think about this? List of things to do:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for the contribution 🎉
Description
Fixes #201 - Half
Type of change
How Has This Been Tested?
composer test
Checklist:
Screenshots