Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusion over Bpp and Bpc #76

Open
Geof23 opened this issue May 18, 2018 · 0 comments
Open

Confusion over Bpp and Bpc #76

Geof23 opened this issue May 18, 2018 · 0 comments

Comments

@Geof23
Copy link

Geof23 commented May 18, 2018

Hey Devs, I've noticed some inconsistency in the handling of ILimage members Bpc and Bpp.

For instance, after creating an ilImage(filename.exr), the image object had a Bpp of 16, where the file object was an RGBA float. Of course, this would be correct if Bpp meant 'bytes per pixel'. However, 'devil_internal_exports.h' indicates that this is actually the number of channels per pixel.

Perhaps this is an inconsistency between the cpp wrapper and the base c implementation. For instance, I added support for 'Blit' in the cpp, and found that it couldn't properly handle the above file. It doesn't seem to handle the float type properly

Anyway, I can provide a diff for the Blit func if you like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant