Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align units in ddlpy_to_hatyan #363

Closed
2 tasks done
veenstrajelmer opened this issue Oct 30, 2024 · 0 comments · Fixed by #364
Closed
2 tasks done

Align units in ddlpy_to_hatyan #363

veenstrajelmer opened this issue Oct 30, 2024 · 0 comments · Fixed by #364

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Oct 30, 2024 •
edited
Loading

Units attr is added to hatyan timeseries since #360.

However, ddlpy_to_hatyan also divides by 100 to convert from meters to centimeters, but the unit attr is not changed.

Todo:

  • check unit and grootheid before dividing by 100
  • align unit attr (so meters instead of cm)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

align units throughout code Deltares/hatyan
1 participant
@veenstrajelmer