Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify timestep_min behaviour #286

Closed
4 tasks done
Tracked by #110
veenstrajelmer opened this issue May 6, 2024 · 0 comments · Fixed by #288
Closed
4 tasks done
Tracked by #110

simplify timestep_min behaviour #286

veenstrajelmer opened this issue May 6, 2024 · 0 comments · Fixed by #288

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented May 6, 2024 •
edited
Loading

  • deprecate timefreq int (only accept freq str), in times and timestep_min argument for prediction
  • rename timestep_min to freq or timestep
  • check if int freq gets raised, not interpreted as n-timestamps.
  • update example scripts
@veenstrajelmer veenstrajelmer mentioned this issue May 6, 2024
Closed
96 tasks
@veenstrajelmer veenstrajelmer changed the title consider deprecating timefreq int (only freq str), in times and timestep_min argument for prediction (rename latter to freq. Do check if int freq gets raised, not interpreted as n-timestamps. simplify timestep_min behaviour May 6, 2024
@veenstrajelmer veenstrajelmer linked a pull request May 6, 2024 that will close this issue
286 simplify timestep min behaviour #288
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

286 simplify timestep min behaviour Deltares/hatyan
1 participant
@veenstrajelmer