Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace times_ext list and timestep_min with slice(tstart,tstop,tstep_min) #104

Closed
veenstrajelmer opened this issue Jul 24, 2023 · 0 comments · Fixed by #143
Closed

Replace times_ext list and timestep_min with slice(tstart,tstop,tstep_min) #104

veenstrajelmer opened this issue Jul 24, 2023 · 0 comments · Fixed by #143

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Jul 24, 2023 •
edited
Loading

Or merge times_ext and times_pred_all, but support both pd.DatatimeIndex and slice. Rename argument to times.

Start again since branch has many merging conflicts: https://github.com/Deltares/hatyan/pull/105/files

Also support string tstart etc, use pd.Timestamp to convert them. This also supports timezones:

pd.Timestamp('2000-01-01 00:01 +01:00')
Out[10]: Timestamp('2000-01-01 00:01:00+0100', tz='pytz.FixedOffset(60)')
@veenstrajelmer veenstrajelmer changed the title Replace times_ext list with slice Replace times_ext list and timestep_min with slice(tstart,tstop,tstep_min) Jul 24, 2023
This was referenced Jun 27, 2023
Closed
Closed
@veenstrajelmer veenstrajelmer linked a pull request Jul 24, 2023 that will close this issue
104 replace times ext list with slice #105
Closed
3 tasks
@veenstrajelmer veenstrajelmer mentioned this issue Aug 3, 2023
Closed
96 tasks
@veenstrajelmer veenstrajelmer linked a pull request Aug 12, 2023 that will close this issue
104 replace times ext list and timestep min #143
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@veenstrajelmer