Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing failing preprocess_interpolate_nc_to_bc.py example script #905

Closed
veenstrajelmer opened this issue Jul 12, 2024 · 0 comments · Fixed by #956
Closed

Consider removing failing preprocess_interpolate_nc_to_bc.py example script #905

veenstrajelmer opened this issue Jul 12, 2024 · 0 comments · Fixed by #956

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Jul 12, 2024

Since #894 was fixed, the example script preprocess_interpolate_nc_to_bc.py fails since forcingmodel_object is not returned anymore in case of tide? Also how to replace A0 or just remove? Also nPoints is not an argument for interpolate_tide_to_bc() anymore.

Also, dfmt.open_dataset_extra() does not work for multiple quantities anymore since #946

Consider removing the example file, does not add much value anymore.

Related to #780

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant