Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update build method #416

Closed
5 tasks done
veenstrajelmer opened this issue Jun 29, 2023 · 0 comments · Fixed by #678
Closed
5 tasks done

update build method #416

veenstrajelmer opened this issue Jun 29, 2023 · 0 comments · Fixed by #678

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Jun 29, 2023

warning is printed when we use the current build method python setup.py sdist bdist_wheel:

Please avoid running ``setup.py`` directly.
Instead, use pypa/build, pypa/installer, pypa/build or
other standards-based tools.
See https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html for details.

Todo:

  • update dev deps: python -m build requires build (so add to dev dependencies).
  • wheel and setuptools can be removed from the dependencies
  • remove setup.py
  • also update github action
  • update contributing docs

Relevant for later: when building on WCF, we get the following error related to the snapvolumestemp folder: pypa/build#703

This was referenced Jul 11, 2023
@veenstrajelmer veenstrajelmer linked a pull request Nov 21, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant