Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Day of year for lake model #239

Closed
verseve opened this issue Dec 13, 2022 · 0 comments · Fixed by #241
Closed

Day of year for lake model #239

verseve opened this issue Dec 13, 2022 · 0 comments · Fixed by #241
Assignees

Comments

@verseve
Copy link
Member

verseve commented Dec 13, 2022

Day of year (DOY) for the lake module is determined in the wflow Python version as follows: wf_DynamicFramework.py, to deal with leap years and input of 365 days (columns) as part of daily rating curves.

In Wflow.jl we just use a maximum of 365 columns as follows: col = min(doy, 365), and deviate from this approach. Would be good to change this to the wflow Python approach.

@verseve verseve self-assigned this Dec 13, 2022
@verseve verseve linked a pull request Jan 12, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant