diff --git a/docs/src/changelog.md b/docs/src/changelog.md index 710cbbf13..f8f661a17 100644 --- a/docs/src/changelog.md +++ b/docs/src/changelog.md @@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 to zero). - In the grid output netCDFs, don't set the `_FillValue` attribute, since the CF conventions don't allow it. +- Glacier parameter `g_sifrac` needs to be converted during initialization (time dependent). ### Changed - Changed depth `h` for reservoir and lake locations as part of the river local inertial diff --git a/docs/src/model_docs/params_vertical.md b/docs/src/model_docs/params_vertical.md index 19b2c1f1c..d8f3033e0 100644 --- a/docs/src/model_docs/params_vertical.md +++ b/docs/src/model_docs/params_vertical.md @@ -27,7 +27,7 @@ specific_leaf = "Sl" | **`cf_soil`** | controls soil infiltration reduction factor when soil is frozen | - | 0.038 | | **`g_tt`** | threshold temperature for snowfall above glacier | ᵒC| 0.0 | | **`g_cfmax`** | Degree-day factor for glacier | mm ᵒC``^{-1}`` Δt``^{-1}``| 3.0 mm ᵒC``^{-1}`` day``^{-1}`` | -| **`g_sifrac`** | fraction of the snowpack on top of the glacier converted into ice | - | 0.001 | +| **`g_sifrac`** | fraction of the snowpack on top of the glacier converted into ice | Δt``^{-1}`` | 0.001 day``^{-1}`` | | **`glacierfrac`** | fraction covered by a glacier | - | 0.0 | | **`glacierstore`** | water within the glacier | mm | 5500.0 | | **`θₛ`** (`theta_s`) | saturated water content (porosity) | - | 0.6 | @@ -134,7 +134,7 @@ internal model parameter to the external netCDF variable. | **`whc`** | water holding capacity as fraction of current snow pack | - | 0.1 | | **`g_tt`** | threshold temperature for snowfall above glacier | ᵒC| 0.0 | | **`g_cfmax`** | Degree-day factor for glacier | mm ᵒC``^{-1}`` Δt``^{-1}``| 3.0 mm ᵒC``^{-1}`` day``^{-1}`` | -| **`g_sifrac`** | fraction of the snowpack on top of the glacier converted into ice | - | 0.001 | +| **`g_sifrac`** | fraction of the snowpack on top of the glacier converted into ice | Δt``^{-1}``| 0.001 day``^{-1}`` | | **`glacierfrac`** | fraction covered by a glacier | - | 0.0 | | **`glacierstore`** | water within the glacier | mm | 5500.0 | | **`fc`** | field capacity | mm | 260.0 | @@ -199,7 +199,7 @@ internal model parameter to the external netCDF variable. | **`cfr`** | refreezing efficiency constant in refreezing of freewater in snow | - | 0.05 | | **`g_tt`** | threshold temperature for snowfall above glacier | ᵒC| 0.0 | | **`g_cfmax`** | Degree-day factor for glacier | mm ᵒC``^{-1}`` Δt``^{-1}``| 3.0 mm ᵒC``^{-1}`` day``^{-1}`` | -| **`g_sifrac`** | fraction of the snowpack on top of the glacier converted into ice | - | 0.001 | +| **`g_sifrac`** | fraction of the snowpack on top of the glacier converted into ice | Δt``^{-1}`` | 0.001 day``^{-1}`` | | **`glacierfrac`** | fraction covered by a glacier | - | 0.0 | | **`glacierstore`** | water within the glacier | mm | 5500.0 | | **`ecorr`** | evaporation correction | - | 1.0 | diff --git a/src/flextopo.jl b/src/flextopo.jl index aec1bb9af..466213d04 100644 --- a/src/flextopo.jl +++ b/src/flextopo.jl @@ -45,8 +45,8 @@ g_tt::Vector{T} | "ᵒC" # Degree-day factor [mm ᵒC⁻¹ Δt⁻¹] for glacier g_cfmax::Vector{T} | "mm ᵒC-1 Δt-1" - # Fraction of the snowpack on top of the glacier converted into ice [-] - g_sifrac::Vector{T} | "-" + # Fraction of the snowpack on top of the glacier converted into ice [Δt⁻¹] + g_sifrac::Vector{T} | "Δt-1" # Water within the glacier [mm] glacierstore::Vector{T} | "mm" # Fraction covered by a glacier [-] diff --git a/src/flextopo_model.jl b/src/flextopo_model.jl index b05e08c10..0ed1ead97 100644 --- a/src/flextopo_model.jl +++ b/src/flextopo_model.jl @@ -93,7 +93,7 @@ function initialize_flextopo_model(config::Config) defaults = 0.001, type = Float, fill = 0.0, - ) + ) .* (Δt / basetimestep) glacierfrac = ncread( nc, config, diff --git a/src/hbv.jl b/src/hbv.jl index b1b1443ed..b5b376d62 100644 --- a/src/hbv.jl +++ b/src/hbv.jl @@ -29,7 +29,7 @@ whc::Vector{T} | "-" # Fraction of snow volume that can store water [-] g_tt::Vector{T} | "ᵒC" # Threshold temperature for snowfall above glacier [ᵒC] g_cfmax::Vector{T} | "mm ᵒC-1 Δt-1" # Degree-day factor [mm ᵒC⁻¹ Δt⁻¹] for glacier - g_sifrac::Vector{T} | "-" # Fraction of the snowpack on top of the glacier converted into ice [-] + g_sifrac::Vector{T} | "Δt-1" # Fraction of the snowpack on top of the glacier converted into ice [Δt⁻¹] glacierstore::Vector{T} | "mm" # Water within the glacier [mm] glacierfrac::Vector{T} | "-" # Fraction covered by a glacier [-] precipitation::Vector{T} # Precipitation [mm Δt⁻¹] diff --git a/src/hbv_model.jl b/src/hbv_model.jl index 7d21ebb6f..5cad79435 100644 --- a/src/hbv_model.jl +++ b/src/hbv_model.jl @@ -70,7 +70,7 @@ function initialize_hbv_model(config::Config) defaults = 0.001, type = Float, fill = 0.0, - ) + ) .* (Δt / basetimestep) glacierfrac = ncread( nc, config, diff --git a/src/sbm.jl b/src/sbm.jl index 8bae77847..57a941e73 100644 --- a/src/sbm.jl +++ b/src/sbm.jl @@ -173,8 +173,8 @@ g_tt::Vector{T} | "ᵒC" # Degree-day factor [mm ᵒC⁻¹ Δt⁻¹] for glacier g_cfmax::Vector{T} | "mm ᵒC-1 Δt-1" - # Fraction of the snowpack on top of the glacier converted into ice [-] - g_sifrac::Vector{T} | "-" + # Fraction of the snowpack on top of the glacier converted into ice [Δt⁻¹] + g_sifrac::Vector{T} | "Δt-1" # Water within the glacier [mm] glacierstore::Vector{T} | "mm" # Fraction covered by a glacier [-] @@ -317,7 +317,7 @@ function initialize_sbm(nc, config, riverfrac, inds) defaults = 0.001, type = Float, fill = 0.0, - ) + ) .* (Δt / basetimestep) glacierfrac = ncread( nc, config,