Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reconsider 20 minute correction in culm_addtime for calc_havengetallen #164

Closed
veenstrajelmer opened this issue Oct 24, 2024 · 0 comments · Fixed by #165
Closed

reconsider 20 minute correction in culm_addtime for calc_havengetallen #164

veenstrajelmer opened this issue Oct 24, 2024 · 0 comments · Fixed by #165

Comments

@veenstrajelmer
Copy link
Collaborator

reconsider 20 minute correction in culm_addtime, this seems odd since we relate it to the moon culmination that happens on the ocean. Compare time reference to Gele Boekje or 1991.0

Reference from Gemiddelde Getijkromme 1991.0:
image

Current settings are:

Result is quite similar to reference:
image

When removing offset of 4 (including time correction) the 0 is not on top anymore:
image

When removing the 20 minute correction the x-axis has an offset:
image

Conclusion, we should keep the offsets as is, but the comments can be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant