Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test dataframe setting on index/slice behaviour in relation to Pandas COW #25

Open
Erik-Geo opened this issue Aug 20, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@Erik-Geo
Copy link
Collaborator

When turning off COW, you are able to set a value on an index or slice of e.g. a LayeredData.data.df like so:

LayeredData.data.df["column"].iloc[slice(0, 2)] = "iets"

This should work. However, COW will default to True starting with Pandas 3.0, so we have to keep an eye on this. Therefore we must create explicit unit tests to test Header and Data (geodataframe) modifications on indices or slices.

According to the authors of Pandas:

"pandas indexing behavior is tricky to understand"

@Erik-Geo Erik-Geo added the enhancement New feature or request label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant