Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactroring FIAT adapter to a general DirectImpact adapter #432

Open
2 tasks
panosatha opened this issue May 1, 2024 · 0 comments
Open
2 tasks

Refactroring FIAT adapter to a general DirectImpact adapter #432

panosatha opened this issue May 1, 2024 · 0 comments
Assignees
@panosatha
Labels
Feature New feature request Maintenance Cleanup, admin & other chore to keep the project running

Comments

@panosatha
Copy link
Contributor

Kind of request

Changing existing functionality

Enhancement Description

FloodAdapt should not explicitly use FIAT or hydromt-FIAT. It should connect with FIAT through an Adapter which would be the implementation of a general DirectImpactModel for FIAT.

Task list

  • Refactor code
  • Write tests

Use case

No response

Additional Context

No response
@panosatha panosatha added Feature New feature request Needs refinement Issues that still need to be discusses, made more concrete or prioritised labels May 1, 2024
@panosatha panosatha self-assigned this May 1, 2024
@panosatha panosatha linked a pull request May 1, 2024 that will close this issue
Fiat adapter refactoring #433
Closed
@savente93 savente93 added Maintenance Cleanup, admin & other chore to keep the project running Backend and removed Needs refinement Issues that still need to be discusses, made more concrete or prioritised Backend labels Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@panosatha panosatha

Labels
Feature New feature request Maintenance Cleanup, admin & other chore to keep the project running
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fiat adapter refactoring Deltares-research/FloodAdapt
2 participants
@savente93 @panosatha