Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Burp Enterprise: Support newer format #11220

Merged
merged 5 commits into from
Nov 12, 2024
Merged

Conversation

Maffooch
Copy link
Contributor

@Maffooch Maffooch commented Nov 7, 2024

  • Simplify/Solidify BurpE parser to work with newer formats
  • Add support for CAPEC plus multiple CWE via vulnerability IDs
  • Clean up finding format

[sc-8300]

@github-actions github-actions bot added settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR ui parser labels Nov 7, 2024
Copy link

dryrunsecurity bot commented Nov 7, 2024

DryRun Security Summary

The provided code changes focus on enhancing the integration and parsing of Burp Enterprise scan reports in the OWASP Dependency-Track application, including updates to configuration files, vulnerability URL generation, and the BurpEnterpriseParser class, as well as the introduction of new unit tests to ensure the continued integrity and security of the application.

Expand for full summary

Summary:

The provided code changes cover various updates and improvements to the OWASP Dependency-Track application, with a focus on enhancing the integration and parsing of Burp Enterprise scan reports. The changes include updates to configuration files, vulnerability URL generation, and the BurpEnterpriseParser class.

From an application security perspective, the key changes are:

  1. Updating Vulnerability Source URLs: The changes to the dojo/settings/settings.dist.py file add new vulnerability source URLs for CAPEC and CWE definitions, which can provide more context and information for users when reviewing security findings.

  2. Improving Vulnerability URL Generation: The changes to the display_tags.py file enhance the vulnerability_url function to handle special cases for vulnerability ID prefixes, ensuring that the generated URLs are correct and accessible.

  3. Enhancing Burp Enterprise Report Parsing: The changes to the dojo/tools/burp_enterprise/parser.py file significantly improve the parsing of Burp Enterprise HTML reports, including more robust HTML parsing, structured extraction of finding details, and better handling of vulnerability IDs and CWE information.

  4. Expanding Unit Tests: The changes to the unittests/tools/test_burp_enterprise_parser.py file introduce new unit tests that cover various formats of the Burp Enterprise scan report, including the identification of security issues such as CORS policy vulnerabilities, WAF detection, HSTS enforcement, and Content Security Policy (CSP) issues.

Overall, these changes focus on improving the security and reliability of the OWASP Dependency-Track application, particularly in the area of integrating and analyzing Burp Enterprise scan reports. The updates to the vulnerability source URLs, URL generation, and the BurpEnterpriseParser class are positive security enhancements, while the expanded unit tests help ensure the continued integrity and security of the application.

Files Changed:

  1. dojo/settings/.settings.dist.py.sha256sum: The SHA-256 hash value of the dojo/settings/.settings.dist.py file has been updated, indicating a change to the configuration file.
  2. dojo/settings/settings.dist.py: The changes add new vulnerability source URLs for CAPEC and CWE definitions, and expand the list of acceptable file types that can be uploaded to DefectDojo objects.
  3. dojo/templatetags/display_tags.py: The changes improve the vulnerability_url function to handle special cases for vulnerability ID prefixes, making the URL generation more robust and reliable.
  4. dojo/tools/burp_enterprise/parser.py: The changes significantly enhance the BurpEnterpriseParser class, improving the parsing of Burp Enterprise HTML reports, extracting structured finding details, and handling vulnerability IDs and CWE information.
  5. unittests/tools/test_burp_enterprise_parser.py: The changes introduce new unit tests that cover various formats of the Burp Enterprise scan report, including the identification of security issues such as CORS policy vulnerabilities, WAF detection, HSTS enforcement, and CSP issues.

Code Analysis

We ran 9 analyzers against 6 files and 0 analyzers had findings. 9 analyzers had no findings.

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Maffooch Maffooch merged commit 9b1fd65 into DefectDojo:bugfix Nov 12, 2024
73 checks passed
@Maffooch Maffooch deleted the burp branch November 12, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parser settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR ui unittests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants