Added check for existing aws account before warning #872
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionello
approved these changes
Nov 21, 2024
| @@ -1113,7 +1114,7 @@ func getProvider(ctx context.Context, loader *compose.Loader) (cliClient.Provide | |||
| providerID = cliClient.ProviderDefang | |||
| } | |||
| case cliClient.ProviderAWS: | |||
| if !awsInEnv() { | |||
| if !awsInEnv() && !awsInConfig(ctx) { | |||
There was a problem hiding this comment.
Do we still need awsInEnv()? I bet awsInConfig() covers that too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a check to see if AWS credentials can be found in config (not whether they are valid) before printing the warning that "AWS environment variables are not set"
Linked Issues
Fixes #850
Checklist