diff --git a/analyzers/solhint/.deepsource/issues/SOLHINT-W1001.toml b/analyzers/solhint/.deepsource/issues/SOLHINT-W1001.toml index 3452266..d323419 100644 --- a/analyzers/solhint/.deepsource/issues/SOLHINT-W1001.toml +++ b/analyzers/solhint/.deepsource/issues/SOLHINT-W1001.toml @@ -4,11 +4,11 @@ severity = "minor" category = "antipattern" weight = 40 description = """ -Function has cyclomatic complexity "current" but allowed no more than maxcompl. +Function has cyclomatic complexity `current` but allowed no more than maxcompl. -## Not Recommended(s) +## Bad Practice 1. High code complexity ```solidity if (a > b) { diff --git a/analyzers/solhint/.deepsource/issues/SOLHINT-W1002.toml b/analyzers/solhint/.deepsource/issues/SOLHINT-W1002.toml index 39ab2be..08b4f76 100644 --- a/analyzers/solhint/.deepsource/issues/SOLHINT-W1002.toml +++ b/analyzers/solhint/.deepsource/issues/SOLHINT-W1002.toml @@ -8,7 +8,7 @@ Enforces the use of Custom Errors over Require and Revert statements -## Not Recommended(s) +## Bad Practice 1. Use of require statement ```solidity require(userBalance >= availableAmount, "Insufficient Balance"); diff --git a/analyzers/solhint/.deepsource/issues/SOLHINT-W1003.toml b/analyzers/solhint/.deepsource/issues/SOLHINT-W1003.toml index 838e2b2..7e41968 100644 --- a/analyzers/solhint/.deepsource/issues/SOLHINT-W1003.toml +++ b/analyzers/solhint/.deepsource/issues/SOLHINT-W1003.toml @@ -8,7 +8,7 @@ Forbid or enforce explicit types (like uint256) that have an alias (like uint). -## Not Recommended(s) +## Bad Practice 1. If explicit is selected ```solidity uint public variableName diff --git a/analyzers/solhint/.deepsource/issues/SOLHINT-W1004.toml b/analyzers/solhint/.deepsource/issues/SOLHINT-W1004.toml index ef63604..4df2d13 100644 --- a/analyzers/solhint/.deepsource/issues/SOLHINT-W1004.toml +++ b/analyzers/solhint/.deepsource/issues/SOLHINT-W1004.toml @@ -4,7 +4,7 @@ severity = "minor" category = "antipattern" weight = 40 description = """ -Function body contains "count" lines but allowed no more than maxlines. +Function body contains `count` lines but allowed no more than maxlines. diff --git a/analyzers/solhint/.deepsource/issues/SOLHINT-W1006.toml b/analyzers/solhint/.deepsource/issues/SOLHINT-W1006.toml index 4fbaf88..3616e71 100644 --- a/analyzers/solhint/.deepsource/issues/SOLHINT-W1006.toml +++ b/analyzers/solhint/.deepsource/issues/SOLHINT-W1006.toml @@ -4,11 +4,11 @@ severity = "minor" category = "antipattern" weight = 40 description = """ -Contract has "some count" states declarations but allowed no more than maxstates. +Contract has `some count` states declarations but allowed no more than maxstates. -## Not Recommended(s) +## Bad Practice 1. High number of states ```solidity diff --git a/analyzers/solhint/.deepsource/issues/SOLHINT-W1007.toml b/analyzers/solhint/.deepsource/issues/SOLHINT-W1007.toml index 5110a29..aa472e6 100644 --- a/analyzers/solhint/.deepsource/issues/SOLHINT-W1007.toml +++ b/analyzers/solhint/.deepsource/issues/SOLHINT-W1007.toml @@ -8,7 +8,7 @@ No console.log/logInt/logBytesX/logString/etc & No hardhat and forge-std console -## Not Recommended(s) +## Bad Practice 1. No console.logX statements ```solidity console.log('test') diff --git a/analyzers/solhint/.deepsource/issues/SOLHINT-W1008.toml b/analyzers/solhint/.deepsource/issues/SOLHINT-W1008.toml index e5b03f3..0c4cc74 100644 --- a/analyzers/solhint/.deepsource/issues/SOLHINT-W1008.toml +++ b/analyzers/solhint/.deepsource/issues/SOLHINT-W1008.toml @@ -8,7 +8,7 @@ Code block has zero statements inside. Exceptions apply. -## Not Recommended(s) +## Bad Practice 1. Empty block on if statement ```solidity if (condition) { } diff --git a/analyzers/solhint/.deepsource/issues/SOLHINT-W1009.toml b/analyzers/solhint/.deepsource/issues/SOLHINT-W1009.toml index 28fb021..12c5c62 100644 --- a/analyzers/solhint/.deepsource/issues/SOLHINT-W1009.toml +++ b/analyzers/solhint/.deepsource/issues/SOLHINT-W1009.toml @@ -8,7 +8,7 @@ Import statement includes an entire file instead of selected symbols. -## Not Recommended(s) +## Bad Practice 1. import all members from a file ```solidity import * from "foo.sol" diff --git a/analyzers/solhint/.deepsource/issues/SOLHINT-W1010.toml b/analyzers/solhint/.deepsource/issues/SOLHINT-W1010.toml index 9138651..f3b6d18 100644 --- a/analyzers/solhint/.deepsource/issues/SOLHINT-W1010.toml +++ b/analyzers/solhint/.deepsource/issues/SOLHINT-W1010.toml @@ -8,7 +8,7 @@ Imported object name is not being used by the contract. -## Not Recommended(s) +## Bad Practice 1. Imported object is not being used ```solidity diff --git a/analyzers/solhint/.deepsource/issues/SOLHINT-W1011.toml b/analyzers/solhint/.deepsource/issues/SOLHINT-W1011.toml index ac58827..6a828a1 100644 --- a/analyzers/solhint/.deepsource/issues/SOLHINT-W1011.toml +++ b/analyzers/solhint/.deepsource/issues/SOLHINT-W1011.toml @@ -4,7 +4,7 @@ severity = "minor" category = "antipattern" weight = 40 description = """ -Variable "name" is unused. +Variable `name` is unused. diff --git a/analyzers/solhint/.deepsource/issues/SOLHINT-W1012.toml b/analyzers/solhint/.deepsource/issues/SOLHINT-W1012.toml index a5aa6b7..90fd6b2 100644 --- a/analyzers/solhint/.deepsource/issues/SOLHINT-W1012.toml +++ b/analyzers/solhint/.deepsource/issues/SOLHINT-W1012.toml @@ -1,4 +1,4 @@ -title = "Enforces the use of ONE Contract per file see [here](https://docs.soliditylang.org/en/v0.8.21/style-guide.html#contract-and-library-names)" +title = "Enforces the use of ONE Contract per file" verbose_name = "one-contract-per-file" severity = "minor" category = "antipattern" diff --git a/analyzers/solhint/.deepsource/issues/SOLHINT-W1013.toml b/analyzers/solhint/.deepsource/issues/SOLHINT-W1013.toml index a0c6846..aecad63 100644 --- a/analyzers/solhint/.deepsource/issues/SOLHINT-W1013.toml +++ b/analyzers/solhint/.deepsource/issues/SOLHINT-W1013.toml @@ -8,7 +8,7 @@ When fallback is not payable you will not be able to receive ethers. -## Not Recommended(s) +## Bad Practice 1. Fallback is not payable ```solidity diff --git a/analyzers/solhint/.deepsource/issues/SOLHINT-W1014.toml b/analyzers/solhint/.deepsource/issues/SOLHINT-W1014.toml index 0e0d41c..d0aefea 100644 --- a/analyzers/solhint/.deepsource/issues/SOLHINT-W1014.toml +++ b/analyzers/solhint/.deepsource/issues/SOLHINT-W1014.toml @@ -8,7 +8,7 @@ Require or revert statement must have a reason string and check that each reason -## Not Recommended(s) +## Bad Practice 1. Require without reason string ```solidity diff --git a/analyzers/solhint/.deepsource/issues/SOLHINT-W1016.toml b/analyzers/solhint/.deepsource/issues/SOLHINT-W1016.toml index 3fff4ba..dcdde27 100644 --- a/analyzers/solhint/.deepsource/issues/SOLHINT-W1016.toml +++ b/analyzers/solhint/.deepsource/issues/SOLHINT-W1016.toml @@ -8,7 +8,7 @@ Check that all public or external functions are override. This is iseful to make -## Not Recommended(s) +## Bad Practice 1. A public function is not an override ```solidity pragma solidity ^0.7.0; diff --git a/analyzers/solhint/.deepsource/issues/SOLHINT-W1017.toml b/analyzers/solhint/.deepsource/issues/SOLHINT-W1017.toml index 95dfb7e..59f6c6a 100644 --- a/analyzers/solhint/.deepsource/issues/SOLHINT-W1017.toml +++ b/analyzers/solhint/.deepsource/issues/SOLHINT-W1017.toml @@ -8,7 +8,7 @@ Enforces the use of double or simple quotes as configured for string literals. V -## Not Recommended(s) +## Bad Practice 1. Configured with single quotes ```solidity diff --git a/analyzers/solhint/.deepsource/issues/SOLHINT-W1021.toml b/analyzers/solhint/.deepsource/issues/SOLHINT-W1021.toml index dd01413..ab2c671 100644 --- a/analyzers/solhint/.deepsource/issues/SOLHINT-W1021.toml +++ b/analyzers/solhint/.deepsource/issues/SOLHINT-W1021.toml @@ -8,7 +8,7 @@ Enforce naming convention on functions for Foundry test cases -## Not Recommended(s) +## Bad Practice 1. Foundry test case with incorrect Function declaration ```solidity function numberIs42() public {} diff --git a/analyzers/solhint/.deepsource/issues/SOLHINT-W1023.toml b/analyzers/solhint/.deepsource/issues/SOLHINT-W1023.toml index e7addb5..d602296 100644 --- a/analyzers/solhint/.deepsource/issues/SOLHINT-W1023.toml +++ b/analyzers/solhint/.deepsource/issues/SOLHINT-W1023.toml @@ -8,7 +8,7 @@ Enforce named parameters for function calls with 4 or more arguments. This rule -## Not Recommended(s) +## Bad Practice 1. Function call with four UNNAMED parameters (default 4) ```solidity functionName(_senderAddress, 1e18, _tokenAddress, _receiverAddress ) diff --git a/analyzers/solhint/.deepsource/issues/SOLHINT-W1027.toml b/analyzers/solhint/.deepsource/issues/SOLHINT-W1027.toml index 30e8cb0..2f91f4c 100644 --- a/analyzers/solhint/.deepsource/issues/SOLHINT-W1027.toml +++ b/analyzers/solhint/.deepsource/issues/SOLHINT-W1027.toml @@ -8,7 +8,7 @@ Solidity v0.8.18 introduced named parameters on the mappings definition. -## Not Recommended(s) +## Bad Practice 1. No naming at all in regular mapping ```solidity mapping(address => uint256)) public tokenBalances; diff --git a/analyzers/solhint/.deepsource/issues/SOLHINT-W1028.toml b/analyzers/solhint/.deepsource/issues/SOLHINT-W1028.toml index e8d168b..14cd315 100644 --- a/analyzers/solhint/.deepsource/issues/SOLHINT-W1028.toml +++ b/analyzers/solhint/.deepsource/issues/SOLHINT-W1028.toml @@ -8,7 +8,7 @@ Enforce the return values of a function to be named -## Not Recommended(s) +## Bad Practice 1. Function definition with UNNAMED return values ```solidity function checkBalance(address wallet) external view returns(uint256) {} diff --git a/analyzers/solhint/.deepsource/issues/SOLHINT-W1029.toml b/analyzers/solhint/.deepsource/issues/SOLHINT-W1029.toml index 4d964f2..6fc308e 100644 --- a/analyzers/solhint/.deepsource/issues/SOLHINT-W1029.toml +++ b/analyzers/solhint/.deepsource/issues/SOLHINT-W1029.toml @@ -8,7 +8,7 @@ Non-external functions and state variables should start with a single underscore -## Not Recommended(s) +## Bad Practice 1. Internal function with incorrect naming ```solidity function thisIsInternal() internal {} diff --git a/analyzers/solhint/.deepsource/issues/SOLHINT-W1032.toml b/analyzers/solhint/.deepsource/issues/SOLHINT-W1032.toml index 97c47ce..909bd8b 100644 --- a/analyzers/solhint/.deepsource/issues/SOLHINT-W1032.toml +++ b/analyzers/solhint/.deepsource/issues/SOLHINT-W1032.toml @@ -8,7 +8,7 @@ Function order is incorrect. -## Not Recommended(s) +## Bad Practice 1. Constructor is placed after other functions ```solidity diff --git a/analyzers/solhint/.deepsource/issues/SOLHINT-W1034.toml b/analyzers/solhint/.deepsource/issues/SOLHINT-W1034.toml index f4e03ed..001952a 100644 --- a/analyzers/solhint/.deepsource/issues/SOLHINT-W1034.toml +++ b/analyzers/solhint/.deepsource/issues/SOLHINT-W1034.toml @@ -8,7 +8,7 @@ Check order of elements in file and inside each contract, according to the style -## Not Recommended(s) +## Bad Practice 1. State variable declaration after function ```solidity diff --git a/analyzers/solhint/.deepsource/issues/SOLHINT-W1035.toml b/analyzers/solhint/.deepsource/issues/SOLHINT-W1035.toml index 974224a..e4ca4ac 100644 --- a/analyzers/solhint/.deepsource/issues/SOLHINT-W1035.toml +++ b/analyzers/solhint/.deepsource/issues/SOLHINT-W1035.toml @@ -8,7 +8,7 @@ Visibility modifier must be first in list of modifiers. -## Not Recommended(s) +## Bad Practice 1. Visibility modifier not placed first ```solidity diff --git a/analyzers/solhint/.deepsource/issues/SOLHINT-W1036.toml b/analyzers/solhint/.deepsource/issues/SOLHINT-W1036.toml index 608aad2..f212960 100644 --- a/analyzers/solhint/.deepsource/issues/SOLHINT-W1036.toml +++ b/analyzers/solhint/.deepsource/issues/SOLHINT-W1036.toml @@ -4,7 +4,7 @@ severity = "major" category = "security" weight = 60 description = """ -Avoid to use ".call.value()()". +Avoid to use `.call.value()()`. diff --git a/analyzers/solhint/.deepsource/issues/SOLHINT-W1037.toml b/analyzers/solhint/.deepsource/issues/SOLHINT-W1037.toml index fc27e5a..7e5300a 100644 --- a/analyzers/solhint/.deepsource/issues/SOLHINT-W1037.toml +++ b/analyzers/solhint/.deepsource/issues/SOLHINT-W1037.toml @@ -8,7 +8,7 @@ Avoid to use low level calls. -## Not Recommended(s) +## Bad Practice 1. Using low level calls ```solidity anyAddress.call(code); diff --git a/analyzers/solhint/.deepsource/issues/SOLHINT-W1038.toml b/analyzers/solhint/.deepsource/issues/SOLHINT-W1038.toml index 1175f90..9a146cf 100644 --- a/analyzers/solhint/.deepsource/issues/SOLHINT-W1038.toml +++ b/analyzers/solhint/.deepsource/issues/SOLHINT-W1038.toml @@ -4,7 +4,7 @@ severity = "major" category = "security" weight = 60 description = """ -Use "keccak256" instead of deprecated "sha3". +Use `keccak256` instead of deprecated `sha3`. diff --git a/analyzers/solhint/.deepsource/issues/SOLHINT-W1039.toml b/analyzers/solhint/.deepsource/issues/SOLHINT-W1039.toml index cb07129..bf8c882 100644 --- a/analyzers/solhint/.deepsource/issues/SOLHINT-W1039.toml +++ b/analyzers/solhint/.deepsource/issues/SOLHINT-W1039.toml @@ -4,7 +4,7 @@ severity = "major" category = "security" weight = 60 description = """ -Use "selfdestruct" instead of deprecated "suicide". +Use `selfdestruct` instead of deprecated `suicide`. diff --git a/analyzers/solhint/.deepsource/issues/SOLHINT-W1040.toml b/analyzers/solhint/.deepsource/issues/SOLHINT-W1040.toml index 15a69ca..040d98a 100644 --- a/analyzers/solhint/.deepsource/issues/SOLHINT-W1040.toml +++ b/analyzers/solhint/.deepsource/issues/SOLHINT-W1040.toml @@ -4,7 +4,7 @@ severity = "major" category = "security" weight = 60 description = """ -"throw" is deprecated, avoid to use it. +`throw` is deprecated, avoid to use it. diff --git a/analyzers/solhint/.deepsource/issues/SOLHINT-W1042.toml b/analyzers/solhint/.deepsource/issues/SOLHINT-W1042.toml index 6e520c9..f1d8bed 100644 --- a/analyzers/solhint/.deepsource/issues/SOLHINT-W1042.toml +++ b/analyzers/solhint/.deepsource/issues/SOLHINT-W1042.toml @@ -4,11 +4,11 @@ severity = "major" category = "security" weight = 60 description = """ -Check result of "send" call. +Check result of `send` call. -## Not Recommended(s) +## Bad Practice 1. result of "send" call ignored ```solidity x.send(55); diff --git a/analyzers/solhint/.deepsource/issues/SOLHINT-W1044.toml b/analyzers/solhint/.deepsource/issues/SOLHINT-W1044.toml index 80e0e8a..497f416 100644 --- a/analyzers/solhint/.deepsource/issues/SOLHINT-W1044.toml +++ b/analyzers/solhint/.deepsource/issues/SOLHINT-W1044.toml @@ -8,7 +8,7 @@ Explicitly mark visibility in function. -## Not Recommended(s) +## Bad Practice 1. Functions without explicitly marked visibility ```solidity function b() { } diff --git a/analyzers/solhint/.deepsource/issues/SOLHINT-W1045.toml b/analyzers/solhint/.deepsource/issues/SOLHINT-W1045.toml index 073b0b1..5d78d0b 100644 --- a/analyzers/solhint/.deepsource/issues/SOLHINT-W1045.toml +++ b/analyzers/solhint/.deepsource/issues/SOLHINT-W1045.toml @@ -8,7 +8,7 @@ Explicitly mark all external contracts as trusted or untrusted. -## Not Recommended(s) +## Bad Practice 1. External contract name without "Trusted" prefix ```solidity Bank.withdraw(100); diff --git a/analyzers/solhint/.deepsource/issues/SOLHINT-W1046.toml b/analyzers/solhint/.deepsource/issues/SOLHINT-W1046.toml index fefb06f..03ce398 100644 --- a/analyzers/solhint/.deepsource/issues/SOLHINT-W1046.toml +++ b/analyzers/solhint/.deepsource/issues/SOLHINT-W1046.toml @@ -4,7 +4,7 @@ severity = "major" category = "security" weight = 60 description = """ -Avoid multiple calls of "send" method in single transaction. +Avoid multiple calls of `send` method in single transaction. diff --git a/analyzers/solhint/.deepsource/issues/SOLHINT-W1049.toml b/analyzers/solhint/.deepsource/issues/SOLHINT-W1049.toml index 870b3f0..dc3e0ef 100644 --- a/analyzers/solhint/.deepsource/issues/SOLHINT-W1049.toml +++ b/analyzers/solhint/.deepsource/issues/SOLHINT-W1049.toml @@ -4,7 +4,7 @@ severity = "major" category = "security" weight = 60 description = """ -Do not rely on "block.blockhash". Miners can influence its value. +Do not rely on `block.blockhash`. Miners can influence its value. diff --git a/analyzers/solhint/.deepsource/issues/SOLHINT-W1051.toml b/analyzers/solhint/.deepsource/issues/SOLHINT-W1051.toml index 8125c87..7b873ac 100644 --- a/analyzers/solhint/.deepsource/issues/SOLHINT-W1051.toml +++ b/analyzers/solhint/.deepsource/issues/SOLHINT-W1051.toml @@ -8,7 +8,7 @@ Possible reentrancy vulnerabilities. Avoid state changes after transfer. -## Not Recommended(s) +## Bad Practice 1. Vulnerable Contract 1 ```solidity diff --git a/analyzers/solhint/utils/issue_gen.py b/analyzers/solhint/utils/issue_gen.py index 65e32d8..c1e72a7 100644 --- a/analyzers/solhint/utils/issue_gen.py +++ b/analyzers/solhint/utils/issue_gen.py @@ -24,7 +24,7 @@ def get_toml_content( ) -> str: """Return the content of the toml file.""" bad_practice_section = ( - f"\n\n## Not Recommended(s)\n{bad_practice}" if bad_practice else "" + f"\n\n## Bad Practice\n{bad_practice}" if bad_practice else "" ) good_practice_section = ( f"\n\n## Recommended\n{good_practice}" if good_practice else "" @@ -62,9 +62,9 @@ def update_issue_tomls() -> None: filepath = _get_toml_path(issue_code) - title = rule.description.removesuffix(".").replace('"', "`") + title = rule.description.replace('"', "`").removesuffix(".") wiki_url = rule.wiki_url - description = rule.description + description = rule.description.replace('"', "`") bad_practice = "\n\n".join( ( f"{idx}. {bad_example['description']}\n" diff --git a/analyzers/solhint/utils/issue_map_gen.py b/analyzers/solhint/utils/issue_map_gen.py index 28b94b6..3e58300 100644 --- a/analyzers/solhint/utils/issue_map_gen.py +++ b/analyzers/solhint/utils/issue_map_gen.py @@ -32,8 +32,8 @@ def get_mapping() -> Dict[str, Dict[str, str]]: rules = get_all_rules() if len(rules) > len(issue_map): - # if the no. of issues in the mapping is less than the no. of detectors, - # then generate the mapping only for the new detectors + # if the no. of issues in the mapping is less than the no. of rules, + # then generate the mapping only for the new rules for rule in rules: if rule.rule_id not in issue_map: next_code = next(generate_code) diff --git a/analyzers/solhint/utils/solhint_rules.json b/analyzers/solhint/utils/solhint_rules.json index 7ffe73a..87ba003 100644 --- a/analyzers/solhint/utils/solhint_rules.json +++ b/analyzers/solhint/utils/solhint_rules.json @@ -41,7 +41,7 @@ "type": "integer" } }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/best-practises/code-complexity.js" + "file": "/solhint/lib/rules/best-practises/code-complexity.js" }, { "ruleId": "custom-errors", @@ -88,7 +88,7 @@ "defaultSetup": "warn", "schema": null }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/best-practises/custom-errors.js" + "file": "/solhint/lib/rules/best-practises/custom-errors.js" }, { "ruleId": "explicit-types", @@ -158,7 +158,7 @@ ] } }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/best-practises/explicit-types.js" + "file": "/solhint/lib/rules/best-practises/explicit-types.js" }, { "ruleId": "function-max-lines", @@ -189,7 +189,7 @@ "minimum": 1 } }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/best-practises/function-max-lines.js" + "file": "/solhint/lib/rules/best-practises/function-max-lines.js" }, { "ruleId": "max-line-length", @@ -220,7 +220,7 @@ "minimum": 1 } }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/best-practises/max-line-length.js" + "file": "/solhint/lib/rules/best-practises/max-line-length.js" }, { "ruleId": "max-states-count", @@ -264,7 +264,7 @@ "type": "integer" } }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/best-practises/max-states-count.js" + "file": "/solhint/lib/rules/best-practises/max-states-count.js" }, { "ruleId": "no-console", @@ -296,7 +296,7 @@ "fixable": true, "schema": null }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/best-practises/no-console.js" + "file": "/solhint/lib/rules/best-practises/no-console.js" }, { "ruleId": "no-empty-blocks", @@ -342,7 +342,7 @@ "defaultSetup": "warn", "schema": null }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/best-practises/no-empty-blocks.js" + "file": "/solhint/lib/rules/best-practises/no-empty-blocks.js" }, { "ruleId": "no-global-import", @@ -383,7 +383,7 @@ "defaultSetup": "warn", "schema": null }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/best-practises/no-global-import.js" + "file": "/solhint/lib/rules/best-practises/no-global-import.js" }, { "ruleId": "no-unused-import", @@ -412,7 +412,7 @@ "defaultSetup": "warn", "schema": null }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/best-practises/no-unused-import.js" + "file": "/solhint/lib/rules/best-practises/no-unused-import.js" }, { "ruleId": "no-unused-vars", @@ -427,7 +427,7 @@ "defaultSetup": "warn", "schema": null }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/best-practises/no-unused-vars.js" + "file": "/solhint/lib/rules/best-practises/no-unused-vars.js" }, { "ruleId": "one-contract-per-file", @@ -448,7 +448,7 @@ "defaultSetup": "warn", "schema": null }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/best-practises/one-contract-per-file.js" + "file": "/solhint/lib/rules/best-practises/one-contract-per-file.js" }, { "ruleId": "payable-fallback", @@ -478,7 +478,7 @@ "fixable": true, "schema": null }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/best-practises/payable-fallback.js" + "file": "/solhint/lib/rules/best-practises/payable-fallback.js" }, { "ruleId": "reason-string", @@ -529,7 +529,7 @@ } } }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/best-practises/reason-string.js" + "file": "/solhint/lib/rules/best-practises/reason-string.js" }, { "ruleId": "constructor-syntax", @@ -544,7 +544,7 @@ "defaultSetup": "warn", "schema": null }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/deprecations/constructor-syntax.js" + "file": "/solhint/lib/rules/deprecations/constructor-syntax.js" }, { "ruleId": "comprehensive-interface", @@ -573,7 +573,7 @@ "defaultSetup": "warn", "schema": null }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/miscellaneous/comprehensive-interface.js" + "file": "/solhint/lib/rules/miscellaneous/comprehensive-interface.js" }, { "ruleId": "quotes", @@ -642,7 +642,7 @@ ] } }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/miscellaneous/quotes.js" + "file": "/solhint/lib/rules/miscellaneous/quotes.js" }, { "ruleId": "const-name-snakecase", @@ -657,7 +657,7 @@ "defaultSetup": "warn", "schema": null }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/naming/const-name-snakecase.js" + "file": "/solhint/lib/rules/naming/const-name-snakecase.js" }, { "ruleId": "contract-name-camelcase", @@ -672,7 +672,7 @@ "defaultSetup": "warn", "schema": null }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/naming/contract-name-camelcase.js" + "file": "/solhint/lib/rules/naming/contract-name-camelcase.js" }, { "ruleId": "event-name-camelcase", @@ -687,7 +687,7 @@ "defaultSetup": "warn", "schema": null }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/naming/event-name-camelcase.js" + "file": "/solhint/lib/rules/naming/event-name-camelcase.js" }, { "ruleId": "foundry-test-functions", @@ -754,7 +754,7 @@ "type": "array" } }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/naming/foundry-test-functions.js" + "file": "/solhint/lib/rules/naming/foundry-test-functions.js" }, { "ruleId": "func-name-mixedcase", @@ -769,7 +769,7 @@ "defaultSetup": "warn", "schema": null }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/naming/func-name-mixedcase.js" + "file": "/solhint/lib/rules/naming/func-name-mixedcase.js" }, { "ruleId": "func-named-parameters", @@ -821,7 +821,7 @@ "type": "integer" } }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/naming/func-named-parameters.js" + "file": "/solhint/lib/rules/naming/func-named-parameters.js" }, { "ruleId": "func-param-name-mixedcase", @@ -836,7 +836,7 @@ "defaultSetup": "warn", "schema": null }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/naming/func-param-name-mixedcase.js" + "file": "/solhint/lib/rules/naming/func-param-name-mixedcase.js" }, { "ruleId": "immutable-vars-naming", @@ -873,7 +873,7 @@ } } }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/naming/immutable-vars-naming.js" + "file": "/solhint/lib/rules/naming/immutable-vars-naming.js" }, { "ruleId": "modifier-name-mixedcase", @@ -888,7 +888,7 @@ "defaultSetup": "warn", "schema": null }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/naming/modifier-name-mixedcase.js" + "file": "/solhint/lib/rules/naming/modifier-name-mixedcase.js" }, { "ruleId": "named-parameters-mapping", @@ -945,7 +945,7 @@ "defaultSetup": "off", "schema": null }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/naming/named-parameters-mapping.js" + "file": "/solhint/lib/rules/naming/named-parameters-mapping.js" }, { "ruleId": "named-return-values", @@ -980,7 +980,7 @@ "defaultSetup": "warn", "schema": null }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/naming/named-return-values.js" + "file": "/solhint/lib/rules/naming/named-return-values.js" }, { "ruleId": "private-vars-leading-underscore", @@ -1070,7 +1070,7 @@ } } }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/naming/private-vars-leading-underscore.js" + "file": "/solhint/lib/rules/naming/private-vars-leading-underscore.js" }, { "ruleId": "use-forbidden-name", @@ -1085,7 +1085,7 @@ "defaultSetup": "warn", "schema": null }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/naming/use-forbidden-name.js" + "file": "/solhint/lib/rules/naming/use-forbidden-name.js" }, { "ruleId": "var-name-mixedcase", @@ -1100,7 +1100,7 @@ "defaultSetup": "warn", "schema": null }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/naming/var-name-mixedcase.js" + "file": "/solhint/lib/rules/naming/var-name-mixedcase.js" }, { "ruleId": "func-order", @@ -1131,7 +1131,7 @@ "defaultSetup": "warn", "schema": null }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/order/func-order.js" + "file": "/solhint/lib/rules/order/func-order.js" }, { "ruleId": "imports-on-top", @@ -1146,7 +1146,7 @@ "defaultSetup": "warn", "schema": null }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/order/imports-on-top.js" + "file": "/solhint/lib/rules/order/imports-on-top.js" }, { "ruleId": "ordering", @@ -1211,7 +1211,7 @@ "defaultSetup": "warn", "schema": null }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/order/ordering.js" + "file": "/solhint/lib/rules/order/ordering.js" }, { "ruleId": "visibility-modifier-order", @@ -1240,7 +1240,7 @@ "defaultSetup": "warn", "schema": null }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/order/visibility-modifier-order.js" + "file": "/solhint/lib/rules/order/visibility-modifier-order.js" }, { "ruleId": "avoid-call-value", @@ -1255,7 +1255,7 @@ "defaultSetup": "warn", "schema": null }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/security/avoid-call-value.js" + "file": "/solhint/lib/rules/security/avoid-call-value.js" }, { "ruleId": "avoid-low-level-calls", @@ -1284,7 +1284,7 @@ "defaultSetup": "warn", "schema": null }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/security/avoid-low-level-calls.js" + "file": "/solhint/lib/rules/security/avoid-low-level-calls.js" }, { "ruleId": "avoid-sha3", @@ -1305,7 +1305,7 @@ "fixable": true, "schema": null }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/security/avoid-sha3.js" + "file": "/solhint/lib/rules/security/avoid-sha3.js" }, { "ruleId": "avoid-suicide", @@ -1320,7 +1320,7 @@ "defaultSetup": "warn", "schema": null }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/security/avoid-suicide.js" + "file": "/solhint/lib/rules/security/avoid-suicide.js" }, { "ruleId": "avoid-throw", @@ -1341,7 +1341,7 @@ "fixable": true, "schema": null }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/security/avoid-throw.js" + "file": "/solhint/lib/rules/security/avoid-throw.js" }, { "ruleId": "avoid-tx-origin", @@ -1356,7 +1356,7 @@ "defaultSetup": "warn", "schema": null }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/security/avoid-tx-origin.js" + "file": "/solhint/lib/rules/security/avoid-tx-origin.js" }, { "ruleId": "check-send-result", @@ -1397,7 +1397,7 @@ "defaultSetup": "warn", "schema": null }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/security/check-send-result.js" + "file": "/solhint/lib/rules/security/check-send-result.js" }, { "ruleId": "compiler-version", @@ -1427,7 +1427,7 @@ "type": "string" } }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/security/compiler-version.js" + "file": "/solhint/lib/rules/security/compiler-version.js" }, { "ruleId": "func-visibility", @@ -1478,7 +1478,7 @@ } } }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/security/func-visibility.js" + "file": "/solhint/lib/rules/security/func-visibility.js" }, { "ruleId": "mark-callable-contracts", @@ -1508,7 +1508,7 @@ "deprecated": true, "schema": null }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/security/mark-callable-contracts.js" + "file": "/solhint/lib/rules/security/mark-callable-contracts.js" }, { "ruleId": "multiple-sends", @@ -1523,7 +1523,7 @@ "defaultSetup": "warn", "schema": null }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/security/multiple-sends.js" + "file": "/solhint/lib/rules/security/multiple-sends.js" }, { "ruleId": "no-complex-fallback", @@ -1538,7 +1538,7 @@ "defaultSetup": "warn", "schema": null }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/security/no-complex-fallback.js" + "file": "/solhint/lib/rules/security/no-complex-fallback.js" }, { "ruleId": "no-inline-assembly", @@ -1553,7 +1553,7 @@ "defaultSetup": "warn", "schema": null }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/security/no-inline-assembly.js" + "file": "/solhint/lib/rules/security/no-inline-assembly.js" }, { "ruleId": "not-rely-on-block-hash", @@ -1568,7 +1568,7 @@ "defaultSetup": "warn", "schema": null }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/security/not-rely-on-block-hash.js" + "file": "/solhint/lib/rules/security/not-rely-on-block-hash.js" }, { "ruleId": "not-rely-on-time", @@ -1583,7 +1583,7 @@ "defaultSetup": "warn", "schema": null }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/security/not-rely-on-time.js" + "file": "/solhint/lib/rules/security/not-rely-on-time.js" }, { "ruleId": "reentrancy", @@ -1624,7 +1624,7 @@ "defaultSetup": "warn", "schema": null }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/security/reentrancy.js" + "file": "/solhint/lib/rules/security/reentrancy.js" }, { "ruleId": "state-visibility", @@ -1639,6 +1639,6 @@ "defaultSetup": "warn", "schema": null }, - "file": "/private/var/folders/y9/dv63vvmn1wq3__k0n39j78rm0000gn/T/tmpnqfctcls/solhint/lib/rules/security/state-visibility.js" + "file": "/solhint/lib/rules/security/state-visibility.js" } ] \ No newline at end of file diff --git a/sarif-parser/tests/sarif_files/solhint.sarif.json b/sarif-parser/tests/sarif_files/solhint.sarif.json index 7369439..9843692 100644 --- a/sarif-parser/tests/sarif_files/solhint.sarif.json +++ b/sarif-parser/tests/sarif_files/solhint.sarif.json @@ -52,7 +52,7 @@ }, { "issue_code": "private-vars-leading-underscore", - "issue_text": "\'userBalance\' should start with _", + "issue_text": "'userBalance' should start with _", "location": { "path": "Reentrancy.sol", "position": { @@ -69,7 +69,7 @@ }, { "issue_code": "private-vars-leading-underscore", - "issue_text": "\'getBalance\' should start with _", + "issue_text": "'getBalance' should start with _", "location": { "path": "Reentrancy.sol", "position": { @@ -137,7 +137,7 @@ }, { "issue_code": "private-vars-leading-underscore", - "issue_text": "\'addToBalance\' should start with _", + "issue_text": "'addToBalance' should start with _", "location": { "path": "Reentrancy.sol", "position": { @@ -171,7 +171,7 @@ }, { "issue_code": "private-vars-leading-underscore", - "issue_text": "\'withdrawBalance\' should start with _", + "issue_text": "'withdrawBalance' should start with _", "location": { "path": "Reentrancy.sol", "position": { @@ -222,7 +222,7 @@ }, { "issue_code": "avoid-call-value", - "issue_text": "Avoid to use \\".call.value()()\\"", + "issue_text": "Avoid to use \".call.value()()\"", "location": { "path": "Reentrancy.sol", "position": { @@ -239,7 +239,7 @@ }, { "issue_code": "avoid-throw", - "issue_text": "\\"throw\\" is deprecated, avoid to use it", + "issue_text": "\"throw\" is deprecated, avoid to use it", "location": { "path": "Reentrancy.sol", "position": { @@ -273,7 +273,7 @@ }, { "issue_code": "private-vars-leading-underscore", - "issue_text": "\'withdrawBalance_fixed\' should start with _", + "issue_text": "'withdrawBalance_fixed' should start with _", "location": { "path": "Reentrancy.sol", "position": { @@ -341,7 +341,7 @@ }, { "issue_code": "avoid-call-value", - "issue_text": "Avoid to use \\".call.value()()\\"", + "issue_text": "Avoid to use \".call.value()()\"", "location": { "path": "Reentrancy.sol", "position": { @@ -358,7 +358,7 @@ }, { "issue_code": "avoid-throw", - "issue_text": "\\"throw\\" is deprecated, avoid to use it", + "issue_text": "\"throw\" is deprecated, avoid to use it", "location": { "path": "Reentrancy.sol", "position": { @@ -392,7 +392,7 @@ }, { "issue_code": "private-vars-leading-underscore", - "issue_text": "\'withdrawBalance_fixed_2\' should start with _", + "issue_text": "'withdrawBalance_fixed_2' should start with _", "location": { "path": "Reentrancy.sol", "position": {