-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(@vtmn/svelte
, @vtmn/react
, vtmn/vue
): use VtmnAlert
as a component
#1464
Conversation
@vtmn/svelte
, @vtmn/react
, vtmn/vue
): use VtmnAlert is used as a component@vtmn/svelte
, @vtmn/react
, vtmn/vue
): use VtmnAlert
as a component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Tlahey, thanks for this PR.
Regarding potential breaking changes, did you check elsewhere than the DKT project but in all repositories of our private GitHub organization?
The only warning I imagine it's about that Alert is an overlay in our design system, (and it is in this "Overlays" category), and here we are allowing to use it also inside interfaces (not overlayed).
https://github.com/orgs/Decathlon/teams/design-system-core-team-design @Sabrinavigil @SimonLeclercq what's your opinion? Will this change also have an impact on the design and documentation of overlay semantics?
@thibault-mahe what's your opinion please regarding these changes?
Thank you very much 🙏
hi! thanks for this PR @Tlahey and for pinging me @lauthieb . Everything is ok for me here, the use of the slot is nice and allows the component to be more flexible, without bringing any breaking change. The only mini breaking change is that the aria-label of the close button is no longer set to "Close toast" by default, which you can quickly change if you want @Tlahey. Okay fo me otherwise. |
Hello @thibault-mahe I've done the fix on the aria-label ;) |
Changes description
Svelte part :
<p>
to<span>
in order to be ISO with other frameworksSvelte / React / Vue :
id
no really necessaryAlso checked https://www.w3.org/WAI/ARIA/apg/patterns/alertdialog/examples/alertdialog/
The div with a role alert doesn't need to have a aria-labelledby /describeby
Context
Checklist
design-system-core-team-design
GitHub team.Does this introduce a breaking change?
Other information