From 6f04b2156a19cccb9954a1aa2bb76013fec63298 Mon Sep 17 00:00:00 2001 From: Ehsan Saei <71217171+esigo@users.noreply.github.com> Date: Fri, 18 Mar 2022 01:10:32 +0100 Subject: [PATCH] MetricStorage dtors (#1270) --- .gitignore | 1 + sdk/include/opentelemetry/sdk/metrics/state/metric_storage.h | 3 +++ 2 files changed, 4 insertions(+) diff --git a/.gitignore b/.gitignore index 8a55a4ca4a..87d2de3921 100644 --- a/.gitignore +++ b/.gitignore @@ -50,3 +50,4 @@ /build tags +.cache/clangd/* diff --git a/sdk/include/opentelemetry/sdk/metrics/state/metric_storage.h b/sdk/include/opentelemetry/sdk/metrics/state/metric_storage.h index fbff04c47f..a2fcb87679 100644 --- a/sdk/include/opentelemetry/sdk/metrics/state/metric_storage.h +++ b/sdk/include/opentelemetry/sdk/metrics/state/metric_storage.h @@ -24,6 +24,8 @@ class MetricStorage opentelemetry::sdk::instrumentationlibrary::InstrumentationLibrary *instrumentation_library, opentelemetry::sdk::resource::Resource *resource, nostd::function_ref callback) noexcept = 0; + + virtual ~MetricStorage() = default; }; class WritableMetricStorage @@ -38,6 +40,7 @@ class WritableMetricStorage virtual void RecordDouble(double value, const opentelemetry::common::KeyValueIterable &attributes) noexcept = 0; + virtual ~WritableMetricStorage() = default; }; class NoopMetricStorage : public MetricStorage