Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only display errors if field has been modified #29

Open
depiction opened this issue Jan 31, 2020 · 3 comments
Open

Only display errors if field has been modified #29

depiction opened this issue Jan 31, 2020 · 3 comments

Comments

@depiction
Copy link

If a field is set to auto focus and a user moves away from the field without making any changes, validation runs and errors display. I think that errors shouldn't be displayed until a field has been modified. Final Form provides the modified meta value, therefore this should be an easy change.

@lookfirst
Copy link

@depiction This project does not seem to be developed any further. If you'd like to try MUI-RFF which is maintained, I invite you. I'm not 100% sure the logic is what you want, so please try it out and let me know over there.

@depiction
Copy link
Author

Yeah, I assumed that this project was dead, despite the fact that React Final Form still uses this in their Material UI demo form. Thanks for suggesting MUI-RFF. I didn't see it come up in any of my searches. However, after looking at the code for it, it has this same problem. I ended up copying the components from this project into custom components then making the necessary changes.

@lookfirst
Copy link

I updated the RFF site (and MUI) to link to MUI-RFF in the docs, so it has both options for discovery. Yes, SEO has been hard on this one for some reason.

If you'd like to discuss over on MUI-RFF, I am open to adding these sorts of features so you don't have to maintain your own fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants