Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txid in jellyfish is using LE order, we might want to use BE for consistency #231

Closed
fuxingloh opened this issue May 16, 2021 · 1 comment · Fixed by #250
Closed

txid in jellyfish is using LE order, we might want to use BE for consistency #231

fuxingloh opened this issue May 16, 2021 · 1 comment · Fixed by #250
Assignees
Labels
kind/feature New feature request priority/urgent-now Urgent fix, as fast as possible triage/accepted Triage has been accepted

Comments

@fuxingloh
Copy link
Contributor

What would you like to be added:

Change txid in jellyfish-transaction when encoded as a string to be formatted as BE order.

  • defid uses LE
  • DeFi Whale uses defid through jellyfish-api-core hence BE
  • DeFi Whale Indexer also uses BE since it's same as above
  • Only jellyfish-transaction uses LE when stored at REST.

We should change to BE for consistency.

@fuxingloh fuxingloh added kind/feature New feature request priority/urgent-now Urgent fix, as fast as possible area/jellyfish-transaction labels May 16, 2021
@fuxingloh fuxingloh added this to the Jellyfish Wallet milestone May 16, 2021
@defichain-bot
Copy link
Member

@fuxingloh: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details

I am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the DeFiCh/oss-governance-bot repository.

@defichain-bot defichain-bot added the needs/triage Waiting for triage to be accepted label May 16, 2021
@fuxingloh fuxingloh added the triage/accepted Triage has been accepted label May 16, 2021
@defichain-bot defichain-bot removed the needs/triage Waiting for triage to be accepted label May 16, 2021
@fuxingloh fuxingloh self-assigned this May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature request priority/urgent-now Urgent fix, as fast as possible triage/accepted Triage has been accepted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants