Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DUSD loan payback bug due to missing short-circuit #885

Merged
merged 7 commits into from
Nov 9, 2021
Merged

Fix DUSD loan payback bug due to missing short-circuit #885

merged 7 commits into from
Nov 9, 2021

Conversation

prasannavl
Copy link
Member

/kind fix

  • This fixes a bug due to which DUSD loans can become unpayable, since the internal consensus call starts searching for a DUSD-DUSD pool pair due to a missing specialised short-circuit for DUSD, while converting interest / excess to DFI.
  • It's a consensus change, and also an all internal consensus change and shouldn't affect any external surface.

Bushstar
Bushstar previously approved these changes Nov 9, 2021
View reviewed changes
@fuxingloh fuxingloh mentioned this pull request Nov 9, 2021
Merged
@prasannavl prasannavl merged commit 5772b6c into master Nov 9, 2021
@prasannavl prasannavl deleted the fix/dusd-loan-payback branch November 9, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mixa84 Mixa84 Mixa84 approved these changes

@Bushstar Bushstar Bushstar left review comments

@bvbfan bvbfan Awaiting requested review from bvbfan

@monstrobishi monstrobishi Awaiting requested review from monstrobishi

@surangap surangap Awaiting requested review from surangap

@uzyn uzyn Awaiting requested review from uzyn

Assignees

@prasannavl prasannavl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@prasannavl @Bushstar @Mixa84 @defichain-bot @bvbfan