diff --git a/src/miner.cpp b/src/miner.cpp index d66ff87912..4f36efde2c 100644 --- a/src/miner.cpp +++ b/src/miner.cpp @@ -239,7 +239,7 @@ std::unique_ptr BlockAssembler::CreateNewBlock(const CScript& sc coinbaseTx.vout.resize(2); // Explicitly set miner reward - coinbaseTx.vout[0].nValue = CalculateCoinbaseReward(blockReward, consensus.dist.masternode); + coinbaseTx.vout[0].nValue = nFees + CalculateCoinbaseReward(blockReward, consensus.dist.masternode); // Community payment always expected coinbaseTx.vout[1].scriptPubKey = consensus.foundationShareScript; diff --git a/test/functional/feature_block_reward.py b/test/functional/feature_block_reward.py new file mode 100644 index 0000000000..41b8c8542a --- /dev/null +++ b/test/functional/feature_block_reward.py @@ -0,0 +1,43 @@ +#!/usr/bin/env python3 +# Copyright (c) 2014-2019 The Bitcoin Core developers +# Copyright (c) DeFi Blockchain Developers +# Distributed under the MIT software license, see the accompanying +# file LICENSE or http://www.opensource.org/licenses/mit-license.php. +"""Test account mining behaviour""" + +from test_framework.test_framework import DefiTestFramework +from test_framework.util import ( + assert_greater_than, + assert_equal +) + +class BlockRewardTest(DefiTestFramework): + def set_test_params(self): + self.num_nodes = 1 + self.setup_clean_chain = True + self.extra_args = [['-txnotokens=0', '-amkheight=50', '-eunosheight=100', '-eunosheight=100', '-subsidytest=1']] + + def run_test(self): + node = self.nodes[0] + node.generate(120) + + newBaseBlockSubsidy = 405.0400 + masternodePortion = 0.3333 # 33.33% + mingBaseReward = newBaseBlockSubsidy * masternodePortion + + result = node.listaccounthistory("mine", {"depth":0}) + assert_equal(result[0]["amounts"][0], f'{mingBaseReward:.8f}@DFI') + + account = node.getnewaddress() + node.utxostoaccount({account: "1.1@0"}) + node.utxostoaccount({account: "1.2@0"}) + node.utxostoaccount({account: "1.3@0"}) + node.generate(1) + + result = node.listaccounthistory("mine", {"depth":0}) + for subResult in result: + if subResult["type"] == "blockReward": + assert_greater_than(subResult["amounts"][0], f'{mingBaseReward:.8f}@DFI') + +if __name__ == '__main__': + BlockRewardTest().main () diff --git a/test/functional/test_runner.py b/test/functional/test_runner.py index dcbee34d74..f32c88bc3b 100755 --- a/test/functional/test_runner.py +++ b/test/functional/test_runner.py @@ -257,6 +257,7 @@ 'feature_burn_address.py', 'feature_eunos_balances.py', 'feature_sendutxosfrom.py', + 'feature_block_reward.py', # Don't append tests at the end to avoid merge conflicts # Put them in a random line within the section that fits their approximate run-time ]