Add -checkpoints-file flag to defid #1347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prasannavl
reviewed
Jun 20, 2022
src/chainparams.cpp
Outdated
| Res UpdateCheckpointsFromFile(CChainParams ¶ms, const std::string &fileName) { | ||
| std::ifstream file(fileName); | ||
| if (!file.good()) { | ||
| return Res::Err("File \"%s\" does not exist.", fileName); |
There was a problem hiding this comment.
Let's make the error message is adaptable to all errors:
Could not read %s. Ensure it exists and has read permissions
prasannavl
reviewed
Jun 20, 2022
Bushstar
approved these changes
Jun 21, 2022
Bushstar
pushed a commit
that referenced
this pull request
Jul 5, 2022
* Add -checkpoints-file flag to defid * Fix lint: use ParseInt32 and add -checkpoints-file to SET_DOC_OPTIONAL * Accepts comments and empty line in checkpoints file * Generic file error message * Trim lines * Move trim_ws from masternodes/token to strencodings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind feature
What this PR does / why we need it:
Add -checkpoint-file=<file_path> flag to overwrite chainparams checkpoints.
To reduce defid datadir memory usage, the prune option is limited as it only prunes bitcoin related data.
Checkpoints are hardcoded in chainparams but some blocks segment are still reaching high memory usage. (50GiB around 800k blocks mark).
This PR let's a user add additional checkpoint to reduce resources usage.
The checkpoints file should be formatted as
height blockhashcheckpoints_file.txtexample :