Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix interest rate string on logs, minor refactor #1325

Merged
merged 1 commit into from
Jun 3, 2022
Merged

Fix interest rate string on logs, minor refactor #1325

merged 1 commit into from
Jun 3, 2022

Conversation

prasannavl
Copy link
Member

/kind fix

  • Break GetInterestPerBlockHighPrecisionString into a fallible TryGetInterestPerBlockHighPrecisionString and infallible method, with a fallback string to Hex.
  • Infallible ones are preferred in the consensus path.

@prasannavl prasannavl merged commit 53a02e2 into master Jun 3, 2022
@prasannavl prasannavl deleted the pvl/interest-rate-str-fix branch June 3, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcorral dcorral dcorral approved these changes

@uzyn uzyn Awaiting requested review from uzyn

@Bushstar Bushstar Awaiting requested review from Bushstar

@Mixa84 Mixa84 Awaiting requested review from Mixa84

@surangap surangap Awaiting requested review from surangap

Assignees

@prasannavl prasannavl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prasannavl @dcorral @defichain-bot