Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify make.sh to use a single target instead of targets #1137

Merged
merged 2 commits into from
Mar 10, 2022

Conversation

prasannavl
Copy link
Member

/kind refactor

  • Change TARGETS env var into TARGET. This brings consistency to how all the commands behave. Previously some commands looped over all, while some didn't.
  • Multi-targets can easily be involved by just calling the commands with different targets set (an use-case that's not seen a necessity so far, other than local, where it's easy to run separately)

Additionally:

  • This also uses major version numbering instead of hashes for GH Actions, which make it easier to maintain and comprehend, while also taking advantage of semver based fixes. Assumption: Rely on GitHub official actions to use major versions safely. The benefits outweigh the reproduciblity guarantee of hashes, when dealing with well known and relied on GH actions.
  • This also makes an attempt to fix the detached HEAD checkouts, that result in -dirty tags being added to release builds.

bvbfan
bvbfan previously approved these changes Mar 10, 2022
Bushstar
Bushstar previously approved these changes Mar 10, 2022
@prasannavl prasannavl dismissed stale reviews from Bushstar and bvbfan via 5ffb944 March 10, 2022 07:51
@prasannavl prasannavl merged commit 76c94bb into master Mar 10, 2022
@prasannavl prasannavl deleted the refactor/refine-make branch March 10, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants