Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masternode activation and resignation delays should be increased #418

Closed
uzyn opened this issue May 24, 2021 · 1 comment
Closed

Masternode activation and resignation delays should be increased #418

uzyn opened this issue May 24, 2021 · 1 comment
Milestone

Comments

@uzyn
Copy link
Contributor

uzyn commented May 24, 2021

What would you like to be added:

It was previously set to be 10 blocks, alongside difficulty adjustment window.

With 1.7, difficulty will be adjusted to 1008 blocks.

Activation and resignation delays for masternodes are now too short (10 and 60 blocks). https://github.com/DeFiCh/ain/blob/master/src/chainparams.cpp#L154-L155 and should be incremented significantly.

Proposing:

  • consensus.mn.activationDelay: 1008 same as difficulty adjustment window
  • consensus.mn.resignDelay: 2 * consensus.mn.activationDelay. i.e. 2016

Why is this needed:

To be in-line with difficulty adjustment window and to improve chain finality.

@uzyn uzyn added this to the 1.7.x - Eunos milestone May 24, 2021
@defichain-bot
Copy link
Member

@uzyn: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details

I am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the DeFiCh/oss-governance-bot repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants