Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include account system changes in block merkle root #349

Closed
monstrobishi opened this issue Apr 26, 2021 · 3 comments · Fixed by #337
Closed

Include account system changes in block merkle root #349

monstrobishi opened this issue Apr 26, 2021 · 3 comments · Fixed by #337
Assignees
Milestone

Comments

@monstrobishi
Copy link
Contributor

What would you like to be added:

Include account system changes in block merkle root, by calculating the entire account state, hashing it and including it as part of the merkle root.

Why is this needed:

Account system state is not currently enforced strongly by the information in the block, encoding the account state as part of the merkle root ensures that account changes are reflected and strongly enforced at every block.

@defichain-bot
Copy link
Member

@monstrobishi: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details

I am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the DeFiCh/oss-governance-bot repository.

@monstrobishi
Copy link
Contributor Author

/triage accepted

@uzyn
Copy link
Contributor

uzyn commented May 17, 2021

Done with #337

@uzyn uzyn closed this as completed May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants