Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM token split: intrinsic.migrateToken does not create tokentransfers #2895

Closed
kuegi opened this issue Apr 16, 2024 · 2 comments
Closed

EVM token split: intrinsic.migrateToken does not create tokentransfers #2895

kuegi opened this issue Apr 16, 2024 · 2 comments
Labels

Comments

@kuegi
Copy link
Contributor

kuegi commented Apr 16, 2024

Summary

when using the migrateToken function on the intrinsic SC, it directly replaces the balances in the DST-20 contracts, but no token transfer is created. so looking at the logs, there is no trace of the split.

Better we add a burn of the old token and mint of the new token to the logs. Otherwise I guess that trackers geht confused/messed up.

see https://testnet-dmc.mydefichain.com:8444/tx/0x5292bf4eef163adff3816cb40a8d5117633f7ddf436b90bc536c984b813b2752 as an example call.

Environment

  • Node Version: 4.1.0-alpha
@kuegi kuegi added the bug label Apr 16, 2024
@prasannavl
Copy link
Member

Thanks for this report @kuegi. This is indeed something to cleanup.

@Jouzo is currently working on a refined iteration of the handling on the EVM layer.

@Jouzo
Copy link
Collaborator

Jouzo commented May 3, 2024

Fixed in #2903

@Jouzo Jouzo closed this as completed May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants