Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing RPC data for PaybackWithCollateral #1536

Closed
sambP opened this issue Nov 1, 2022 · 8 comments
Closed

Missing RPC data for PaybackWithCollateral #1536

sambP opened this issue Nov 1, 2022 · 8 comments
Labels
p2 Medium priority

Comments

@sambP
Copy link

sambP commented Nov 1, 2022

If I'm not missing something, there isn't any way to check what really happened in the vault after a PaybackWithCollateral. This breaks our whole balance calculation. Wouldn't it be possible to add at least a vaultSnapshot, like after an auction?

@defichain-bot
Copy link
Member

@sambP: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details

I am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the DeFiCh/oss-governance-bot repository.

@shohamc1
Copy link
Contributor

shohamc1 commented Nov 2, 2022

I'm not too sure on what data seems to be missing, could you provide an example? How does it break the balance calculation?

@sambP
Copy link
Author

sambP commented Nov 2, 2022

Sure, here is an (to me unrelated...) example:

This is a paybackAsCollateral tx: https://defiscan.live/transactions/5dee7ca7019137fee6ccb20f2589c53bdddaf7f6d233bea4e27c2faf50a312e3

The customTx looks like this:
{"valid":true,"type":"PaybackWithCollateral","results":{"vaultId":"591882453d1c682bbc1aaaddaf5b0b3801416e1089386b99581c28f28dbb5bfc"}}

listvaulthistory 591882453d1c682bbc1aaaddaf5b0b3801416e1089386b99581c28f28dbb5bfc blockHeight: 2258841
no response

listaccounthistory dTGeTGkayryJFi1tc6ERNnsL7eo4G5CbaZ blockHeight: 2258841
no response

There is no information about how much collateral in the vault repays the how much loan. So it is currently absolutely impossible to collect historical changes in a vault if this feature was used.

@sandstumpen
Copy link

@shohamc1
Is there any new information here yet? This function is very important for me for the creation of tax reports.
Thx

@pegasus2003
Copy link

Sounds like a great idea

@phigo90
Copy link

phigo90 commented Jan 19, 2023

I would even go one step further. The complete solution would be to track the incurred interest in a kind of vault history. Similar to how it is currently done with listaccounthistory for e.g. the LM rewards.

@RomanShumkov
Copy link

I would even go one step further. The complete solution would be to track the incurred interest in a kind of vault history. Similar to how it is currently done with listaccounthistory for e.g. the LM rewards.

Feel free to give thumbs up here: #957

@prasannavl prasannavl added the p2 Medium priority label Jan 20, 2023
@prasannavl
Copy link
Member

Quick update: We're looking into this. Will add more details soon (hopefully next week).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2 Medium priority
Projects
None yet
Development

No branches or pull requests

8 participants