-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing RPC data for PaybackWithCollateral #1536
Comments
@sambP: Thanks for opening an issue, it is currently awaiting triage. The triage/accepted label can be added by foundation members by writing /triage accepted in a comment. DetailsI am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the DeFiCh/oss-governance-bot repository. |
I'm not too sure on what data seems to be missing, could you provide an example? How does it break the balance calculation? |
Sure, here is an (to me unrelated...) example: This is a paybackAsCollateral tx: https://defiscan.live/transactions/5dee7ca7019137fee6ccb20f2589c53bdddaf7f6d233bea4e27c2faf50a312e3 The customTx looks like this: listvaulthistory 591882453d1c682bbc1aaaddaf5b0b3801416e1089386b99581c28f28dbb5bfc blockHeight: 2258841 listaccounthistory dTGeTGkayryJFi1tc6ERNnsL7eo4G5CbaZ blockHeight: 2258841 There is no information about how much collateral in the vault repays the how much loan. So it is currently absolutely impossible to collect historical changes in a vault if this feature was used. |
@shohamc1 |
Sounds like a great idea |
I would even go one step further. The complete solution would be to track the incurred interest in a kind of vault history. Similar to how it is currently done with listaccounthistory for e.g. the LM rewards. |
Feel free to give thumbs up here: #957 |
Quick update: We're looking into this. Will add more details soon (hopefully next week). |
If I'm not missing something, there isn't any way to check what really happened in the vault after a PaybackWithCollateral. This breaks our whole balance calculation. Wouldn't it be possible to add at least a vaultSnapshot, like after an auction?
The text was updated successfully, but these errors were encountered: