Make CLockFreeGuard safer

DeFiCh · Mar 3, 2023 · 40eafe9 · 40eafe9
1 parent 5e3f1c7
commit 40eafe9
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/src/sync.h b/src/sync.h
@@ -337,17 +337,16 @@ class CLockFreeGuard
 public:
     CLockFreeGuard(std::atomic_bool& lock) : lock(lock)
     {
-        bool desired = false;
-        while (!lock.compare_exchange_weak(desired, true,
-                                           std::memory_order_release,
-                                           std::memory_order_relaxed)) {
-            desired = false;
-            std::this_thread::sleep_for(std::chrono::milliseconds(1));
+        bool expected = false;
+        while (!lock.compare_exchange_weak(expected, true)) {
+            expected = false;
+            // std::this_thread::sleep_for(std::chrono::milliseconds(1));
         }
     }
+
     ~CLockFreeGuard()
     {
-        lock.store(false, std::memory_order_release);
+        lock.store(false);
     }
 };