Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make discarded MST blocks hang around for a bit? #14

Open
DavidBuchanan314 opened this issue Nov 16, 2024 · 0 comments
Open

Make discarded MST blocks hang around for a bit? #14

DavidBuchanan314 opened this issue Nov 16, 2024 · 0 comments

Comments

@DavidBuchanan314
Copy link
Owner

DavidBuchanan314 commented Nov 16, 2024

Currently, we delete an MST block from the db the moment it's no longer needed for the current state of the db.

If someone is walking the MST via something like getBlocks, and the repo changes midway through, they'll get errors. If the repo is being updated rapidly, they'll probably never get a full read.

Rather than deleting them instantly we could tombstone them and garbage collect after some delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant