Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New features, refactoring and replacement of Flask by Quart #6

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

benoit-garcia
Copy link

@benoit-garcia benoit-garcia commented Jan 24, 2023

This PR contains several changes:

New features:

  • Two new routes were added to support Terraform operations. Terraform need to be installed on the running host. Beware that terraform operations may take some time. I advise increasing the time out duration on gitea if you plan to use it. This is done by editing the value of the DELIVER_TIMEOUT parameter in the webhook section.
  • Allow the use of SSH instead of HTTP(s) when cloning repositories. The default setting remains HTTP(s).

Refactoring

  • In order to improve readability of code, and to ease the addition of new routes, the application is now split in several files.
  • Inclusion of __pycache__ and .venv directories to the list of files ignored by git.
  • Creation of a .editorconfig file to helps maintaining consistent coding styles (see editconfig.org for more information).
  • The main application is now defined as a module (see the runner directory, however the starting script (tea-runner.py) can be use all the same.

Breaking changes:

In order to use background tasks in the future, tea-runner is now using:

Code style

  • Imports were re-ordered, following PEP-0008.
  • All code has been formatted using Black.

@benoit-garcia benoit-garcia changed the title Add basic support of terraform and ssh protocol New features, refactoring and replacement of Flask by Quart Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant