Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stoch SMMA init bug #1108

Merged
merged 1 commit into from
Nov 4, 2023
Merged

Conversation

DaveSkender
Copy link
Owner

Description

When using a specific quote history size with STC, it attempts to initialize the SMMA variant of the underlying Stoch indicator, which is entirely unnecessary. We've removed the superfluous initialization.

Fixes #1107

Checklist

  • My code follows the existing style, code structure, and naming taxonomy
  • I have put comments in my code, particularly for hard-to-understand areas
  • I have performed a self-review of my code and included any verifying manual calculations
  • I have added or updated unit tests that prove my fix is effective or that my feature works and achieves sufficient code coverage. New and existing unit tests pass locally and in the build (below) with my changes
  • My changes generate no new warnings or other code analysis issues
  • I have added or run the performance tests that depict optimal execution times
  • I have made corresponding changes to the documentation

@MhAllan, thank you for reporting.

@DaveSkender DaveSkender linked an issue Nov 4, 2023 that may be closed by this pull request
@DaveSkender DaveSkender merged commit aba673c into main Nov 4, 2023
4 checks passed
@DaveSkender DaveSkender deleted the 1107-stc-bug-out-of-range-exception branch November 4, 2023 08:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Stc Bug - Out of range exception
1 participant