Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Candle Properties not accessible #1027

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

RobertWeaver
Copy link
Contributor

@RobertWeaver RobertWeaver commented Feb 16, 2023

Closes #1026

Checklist

  • My code follows the existing style, code structure, and naming taxonomy
  • I have put comments in my code, particularly for hard-to-understand areas
  • I have performed a self-review of my code and included any verifying manual calculations
  • I have added or updated unit tests that prove my fix is effective or that my feature works and achieves sufficient code coverage. New and existing unit tests pass locally and in the build (below) with my changes
  • My changes generate no new warnings or other code analysis issues
  • I have added or run the performance tests that depict optimal execution times
  • I have made corresponding changes to the documentation

@DaveSkender DaveSkender merged commit 6bc622f into DaveSkender:main Feb 16, 2023
@DaveSkender
Copy link
Owner

Thank you!

@DaveSkender
Copy link
Owner

@RobertWeaver one aspect we didn’t fix is the ability to carryover custom properties when using .ToCandle(). You can however, start with that model to customize and just populate the base OHLCV values.

public class MyCustomQuote : CandleProperties, IQuote {}

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Candle Properties not accessible
2 participants