Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'Visualize BackTest Result' #1021

Closed
wants to merge 1 commit into from
Closed

Conversation

tiger2014
Copy link
Contributor

@tiger2014 tiger2014 commented Feb 11, 2023

Description

Let the backtest result be visualized with simple method

@tiger2014
Copy link
Contributor Author

tiger2014 commented Feb 11, 2023

This is very a simple sample. Hope someone knowing more about the frontend can add a pane for indicators (i.e. MACD, RSI) on this chart. Thanks!

@DaveSkender DaveSkender marked this pull request as draft February 12, 2023 01:43
@DaveSkender
Copy link
Owner

DaveSkender commented Feb 12, 2023

The only place I’d consider putting something like this is in the example project. I’m not keen on putting front-end rendering pieces here. It might make a good, but separate, add-on package as part of a separate backtest project, #484

Copy link
Owner

@DaveSkender DaveSkender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can’t be part of the core library since it’s out of scope. See notes above.

@tiger2014
Copy link
Contributor Author

I see

@DaveSkender
Copy link
Owner

DaveSkender commented Feb 12, 2023

Another option here is to just make a standalone example and upload it to your original "show and tell" discussion here: #1005

@DaveSkender
Copy link
Owner

Transferred to discussion

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants