Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: fixes (notice timestamp)
wrong:
correct:
Longer explanation: in some broker such as binance you can't fetch more than 1000 OHLCV records at the same time. You therefore need to fetch them in batches.
Without this fix, the second time the
while True
loop in_fetch_ohlcv
will fetch again the same batch, not add it to the main data pool and break the loop thinking no new data has been added.This results in old data delivered in the strategy as live ones.
This fix allows you to walk through the data until the current point in time resulting in correct LIVE data delivered to the strategy