Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vizbuilder] modify LinePlot cutoff behavior to show top 10 when there are too many #296

Closed
davelandry opened this issue Nov 16, 2018 · 5 comments · Fixed by #329
Closed
Assignees

Comments

@davelandry
Copy link
Member

https://joshua-tree.datausa.io/visualize?groups=0-Zam5D&measure=Z1gCJfh

@frabarz
Copy link
Collaborator

frabarz commented Nov 19, 2018

these are caused because some data combinations don't pass the list of conditions for charts
to explain it shortly: the visualizations array is the list of available charts, we check the query conditions and remove the charts that shouldn't be shown, the list of visualizations ends up empty

@davelandry
Copy link
Member Author

I understand that, but why exactly are we not able to see any visualizations here? Is it because we limit the number of items to be drawn in a line chart? I would expect to see a line chart over time with a line for each university.

@frabarz
Copy link
Collaborator

frabarz commented Nov 20, 2018

For this specific case, linecharts are removed because there would be 3840 lines drawn. The rule we set was to hide linechart for more than 60 lines.
If you limit the members for the grouping to a reasonable number, the charts appear again.

@davelandry
Copy link
Member Author

Could we have it work so that if there are more than 60 lines to draw, we only draw the top 10? We could then prepend the viz title with "Top 10 ..."

@davelandry davelandry changed the title [vizbuilder] "empty dataset" but the top/bottom 10 shows [vizbuilder] modify LinePlot cutoff behavior to show top 10 when there are too many Nov 20, 2018
@davelandry
Copy link
Member Author

@frabarz what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants