-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Support String Value for Record Source and LDTS in HUBS/SATS/LINKS as we do for Staging #189
Comments
Probably some benefit instead of have unnecessary columns for LDTS and RECORD SOURCE in Staging layer. |
Hi, Welcome and thanks for your suggestion. Whilst the idea makes sense on paper, I can't think of a use case where we wouldn't want the There are a few reasons for the current implementation at this time:
For the above reasons I'm not sure having these columns in the stage is unnecessary. It is in fact quite standard. Saying all this, we're not against adding this if it's seen to be useful by the wider community. Could you help us understand where this might be used? Thanks! |
Hi Alex,
Actually, the value will be sourced from a macro and reference the dbt node name so the value will change depending on the model its referencing so technically it isn’t hardcoded as such.
We use a control table for our LDTS so depending on the model it will retrieve the control date from that source.
Understand typically its in the staging table but since its possible to support macros we can be a bit creative how we now populate this value downstream.
Thanks
<ADMIN EDITED TO REMOVE EMAIL WRAPPER>
|
Yeah this makes sense. Sometimes record sources are actually codes and it is good practice to have a lookup table which maps these to system names. I presume this is what you mean? Sounds like you have a macro to do this kind of lookup |
Correct, I already use a macro for the Data Source aka Folder name retrieved from the node in STG.
It makes it more useable from a coding point than having columns for the sake of it.
<ADMIN EDITED TO REMOVE EMAIL WRAPPER>
|
Currently the Staging method supports string values, e.g.
derived_columns:
SOURCE_SYSTEM: '!{{ somevalue }}'
INSTANCE: '!someinstance'
It would be nice to support the string value in Hubs/links/sats methods as well instead of just a column value.
Describe the solution you'd like
Support the use of string values, e.g. ! for LDTS and RECORD SOURCE
AB#5363
The text was updated successfully, but these errors were encountered: