-
Notifications
You must be signed in to change notification settings - Fork 0
required drilldown/cut on geo and year dims, acs #188
Comments
@hwchen for location profiles, we have some queries that look for national comparison values (which is probably what this is). I will go in and add a cut for the US. |
I only found one instance in the profile where we were querying an ACS table without a Geo cut (the one @hwchen mentioned). Regarding the vizbuilder, this means that we need to communicate through annotations if a cut is required if not specified. I'm not sure what's the best way to annotate that... |
I have a
|
@frabarz what do you think about this? will this be sufficient for the vizbuider? |
I'm not sure if I understand correctly. |
@frabarz basically if @hwchen let me know if that sounds right? |
@frabarz so for an example use case:
|
I think we've discussed this in Slack (unless I remembered incorrectly) that all Geography and Year dims could have the assumption that they need to be drilled down. I'm going to close this for now, and reopen if this is incorrect and you'd like another behavior. |
Ahh ok, well that's something. I can see where it would be tedious to go in and add that annotation to every dimension. @frabarz what do you think? should we just do a prop to the React component that lets the users specify additional required dimension drilldowns? We already always drilldown on Year, but in this case we would need to add a fallback "Geography - Nation" drilldown if none is specified by the user. I'm not sure of how widespread the need for this is across other projects, so that might also dictate the solution here. |
If we want the vizbuilder be prepared to handle this for any project, a component property is a good way; if isn't set it just works normally. Configuring it isn't a problem. EDIT: wait a sec, maybe I understood it wrong. Having |
For It's definitely the case that queries to So, I guess this means that I should add an annotation for The annotation will be: |
Yeah, I'm thinking let's not overcomplicate this. @hwchen please add @frabarz you can get going by testing this with the "Health Coverage" cube mentioned above. I've created an issue here: Datawheel/canon#307 |
I think that I've added the |
A change was made recently (a few weeks ago) where there are no longer default members for geo. Year has never had a default member.
Because of this, not drilling down or cutting on the geo dimension in the acs results in incorrect values.
Below is an example in the massachusetts profile as of 10/27/2018:
Also, it's possible that the vizbuilder will have to handle default values a little differently because of this change.
Sorry about making this change, but the cube is way faster because of the change in structure!
cc @davelandry @cnavarreteliz @frabarz
The text was updated successfully, but these errors were encountered: